75 - Replace forEach() and push() with filter() in test-webcrypto-key… #49778
Conversation
|
Thanks for the contribution! The change looks good, though I think it may fail the lint check for being too long. The commit message also needs to be amended to be less than 72 characters per line. You can edit the commit message with |
e55800d to
6237ccb
Compare
|
The subsystem in your commit message will need to match one of the subsystems listed in the check here: https://github.com/nodejs/node/actions/runs/6278585916/job/17052917835?pr=49778 I would recommend Also, you can add an additional description to the commit message with an empty line before it. Something like: |
6237ccb to
b1d83c9
Compare
There was a problem hiding this comment.
Thanks for your contribution, could you please adjust the commit message? It must contain the namespace, in your case, test. Therefore, the new message should be:
test: improve test-webcrypto-keygen.js legibility
you can do this by running:
git commit --amend -> adjust your message
git push -f origin remove_push_forEach_with_filter
b1d83c9 to
d6557f6
Compare
There was a problem hiding this comment.
@SaiHemanth-uab can you update your commit to include your user and email? The easiest way is git config user.name "YOURUSER", git config user.email "yourmail@provider.com" and, git commit --amend --resetAuthor`
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Adding stalled, as the comment was never addressed |
…gen.js [Sai Hemanth Maremalla]