test: skip test-runner-watch-mode on IBMi #48473
Conversation
|
Review requested:
|
|
CC @nodejs/platform-ibmi |
|
Thanks for pointing out that I've been trying to search on the repo and find technical reason why its unsupported by searching with: https://github.com/nodejs/node/issues?q=fs.watch+ibmi I haven't found much info on the reason its unsupported yet. Is fs.watchFile also not supported? The test case |
I would assume that it is not implemented in libuv, but I was only able to find this #30819
it uses |
|
Thanks for the additional info! I agree since its using watch API and that is unsupported on IBM i we should skip this test. |
|
Landed in 0afd6e8 |
PR-URL: #48473 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#48473 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#48473 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #48473 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #48473 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Fixes #48065
this skip exists in 21 other places: https://github.com/search?q=repo%3Anodejs%2Fnode+%22IBMi+does+not+support+%60fs.watch%28%29%60%22&type=code