esm: handle more error types thrown from the loader thread#48247
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 1, 2023
Merged
esm: handle more error types thrown from the loader thread#48247nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
ljharb
reviewed
May 30, 2023
GeoffreyBooth
approved these changes
May 31, 2023
Collaborator
MoLow
approved these changes
May 31, 2023
JakobJingleheimer
approved these changes
May 31, 2023
Member
There was a problem hiding this comment.
Awesome, thanks!
The new test-cases seem a bit verbose; could they be DRY'd up with a loop (for (const valid of […]) and possibly for (const invalid of […]))?
Comment on lines
+51
to
+54
| if (status === 'success' || body === null || | ||
| (typeof body !== 'object' && | ||
| typeof body !== 'function' && | ||
| typeof body !== 'symbol')) { |
Member
There was a problem hiding this comment.
Nit
Suggested change
| if (status === 'success' || body === null || | |
| (typeof body !== 'object' && | |
| typeof body !== 'function' && | |
| typeof body !== 'symbol')) { | |
| if (status === 'success' || body === null || | |
| (typeof body !== 'object' && | |
| typeof body !== 'function' && | |
| typeof body !== 'symbol') | |
| ) { |
Contributor
Author
There are on the same structure than almost every other test cases in that file, that seems fine to me. IMO test code should be WET code, not DRY. |
Collaborator
Collaborator
Collaborator
Collaborator
|
Landed in d28f1f1 |
This was referenced Jun 2, 2023
This was referenced Jun 5, 2023
franciszek-koltuniuk-red
pushed a commit
to franciszek-koltuniuk-red/node
that referenced
this pull request
Jun 7, 2023
PR-URL: nodejs#48247 Refs: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
Contributor
|
This is blocked by another PR that needs to be backported to v18.x because it references missing code. |
Contributor
Author
|
For reference, backporting this is blocked until #44710 is backported. |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48247 Refs: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48247 Refs: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#48247 Refs: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48247 Backport-PR-URL: nodejs/node#50669 Refs: nodejs/node#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#48247 Backport-PR-URL: nodejs/node#50669 Refs: nodejs/node#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #48240