src: use UNREACHABLE instead of CHECK(falsy) #46317
Merged
+14
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some dead code following such statements.
Collaborator
|
Review requested:
|
RaisinTen
approved these changes
Jan 23, 2023
addaleax
approved these changes
Jan 23, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
anonrig
approved these changes
Jan 23, 2023
lpinca
approved these changes
Jan 23, 2023
13 tasks
12 tasks
fhinkel
approved these changes
Jan 25, 2023
Collaborator
|
Landed in f0e6453 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
Also remove some dead code following such statements. PR-URL: #46317 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
Also remove some dead code following such statements. PR-URL: #46317 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
Also remove some dead code following such statements. PR-URL: #46317 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
Also remove some dead code following such statements. PR-URL: #46317 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove some dead code following such statements.