8000 esm: rewrite loader hooks test by GeoffreyBooth · Pull Request #46016 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    esm: rewrite loader hooks test #46016

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Merged
    nodejs-github-bot merged 3 commits into from
    Dec 31, 2022
    Merged

    esm: rewrite loader hooks test #46016

    nodejs-github-bot merged 3 commits into from
    Dec 31, 2022
    +115 −81

    Conversation

    8000
    @GeoffreyBooth
    Copy link
    Member
    @GeoffreyBooth GeoffreyBooth commented Dec 29, 2022 •
    edited
    Loading

    This is a spinoff from #44710. As part of that work, I needed to rewrite this test to no longer depend on internals and invoke ESMLoader directly; instead it spawns a node child process like most of the other loaders tests. The same result is confirmed, and this version of the test is less coupled to internal implementation details. I’m opening this as a standalone PR to confirm that this test passes for pre-refactor loaders code too, and to reduce the diff in the off-thread PR.

    @nodejs/loaders @nodejs/modules @nodejs/testing

    @GeoffreyBooth GeoffreyBooth added test Issues and PRs related to the tests. loaders Issues and PRs related to ES module loaders labels Dec 29, 2022
    @nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Dec 29, 2022
    @GeoffreyBooth
    esm: rewrite loader hooks test
    8c07ea8 
    Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.
    @GeoffreyBooth GeoffreyBooth force-pushed the rewrite-loader-hooks-test branch from 64342b5 to 8c07ea8 Compare December 29, 2022 21:28
    aduh95
    aduh95 reviewed Dec 30, 2022
    View reviewed changes
    GeoffreyBooth and others added 2 commits December 29, 2022 17:25
    @GeoffreyBooth @aduh95
    Apply suggestions from code review
    7b5e399 
    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @GeoffreyBooth
    Still on main thread, so console.log still works
    0f71685
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Dec 30, 2022

    CI: https://ci.nodejs.org/job/node-test-pull-request/48764/

    @GeoffreyBooth GeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 30, 2022
    JakobJingleheimer
    JakobJingleheimer approved these changes Dec 31, 2022
    View reviewed changes
    Copy link
    Member
    @JakobJingleheimer JakobJingleheimer left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @GeoffreyBooth GeoffreyBooth added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Dec 31, 2022
    @nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 31, 2022
    @nodejs-github-bot nodejs-github-bot merged commit e2dd139 into nodejs:main Dec 31, 2022
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Dec 31, 2022

    Landed in e2dd139

    targos pushed a commit that referenced this pull request Jan 1, 2023
    @GeoffreyBooth @targos
    esm: rewrite loader hooks test
    ecc25c3 
    Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.

PR-URL: #46016
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
    @GeoffreyBooth GeoffreyBooth mentioned this pull request Jan 2, 2023
    Merged
    @RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
    Merged
    RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
    @GeoffreyBooth @RafaelGSS
    esm: rewrite loader hooks test
    8e96c99 
    Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.

PR-URL: #46016
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
    RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
    @GeoffreyBooth @RafaelGSS
    esm: rewrite loader hooks test
    2d49e0e 
    Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.

PR-URL: #46016
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
    @GeoffreyBooth GeoffreyBooth deleted the rewrite-loader-hooks-test branch January 17, 2023 18:23
    juanarbol pushed a commit that referenced this pull request Jan 26, 2023
    @GeoffreyBooth @juanarbol
    esm: rewrite loader hooks test
    e33ceac 
    Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.

PR-URL: #46016
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
    @juanarbol juanarbol mentioned this pull request Jan 28, 2023
    Merged
    juanarbol pushed a commit that referenced this pull request Jan 31, 2023
    @GeoffreyBooth @juanarbol
    esm: rewrite loader hooks test
    0bdf2db 
    Rewrite the test that validates that custom loader hooks are called from
being a test that depends on internals to one that spawns a child
process and checks its output to confirm expected behavior.

PR-URL: #46016
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @aduh95 aduh95 aduh95 approved these changes

    @JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

    Assignees

    No one assigned

    Labels

    author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders test Issues and PRs related to the tests.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @GeoffreyBooth @nodejs-github-bot @JakobJingleheimer @aduh95
    0