8000 test: fix flaky unrefed timers test by Trott · Pull Request #4599 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

test: fix flaky unrefed timers test #4599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: fix flaky unrefed timers test #4599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to l 8000 oad files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel/test-timers-unrefd-interval-still-fires.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const common = require('../common');

const TEST_DURATION = common.platformTimeout(100);
const N = 5;
const N = 3;
var nbIntervalFired = 0;

const keepOpen = setTimeout(() => {
Expand All @@ -20,7 +20,7 @@ const timer = setInterval(() => {
timer._onTimeout = () => {
throw new Error('Unrefd interval fired after being cleared.');
};
setImmediate(() => clearTimeout(keepOpen));
clearTimeout(keepOpen);
}
}, 1);

Expand Down
0