stream: update todo message for detached buffers #45464
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
reviewed
Nov 15, 2022
| function isDetachedBuffer(buffer) { | ||
| if (ArrayBufferGetByteLength(buffer) === 0) { | ||
| // TODO(daeyeon): Consider using C++ builtin to improve performance. | ||
| // Replace this when current v8 is updated to include the following commit: |
There was a problem hiding this comment.
Suggested change
| // Replace this when current v8 is updated to include the following commit: | |
| // Replace this when current V8 is updated to include the following commit: |
|
LGTM, but you'll need to rebase against the main branch to pick up the fix for the linting problems. |
lpinca
approved these changes
Nov 15, 2022
targos
reviewed
Nov 15, 2022
| if (ArrayBufferGetByteLength(buffer) === 0) { | ||
| // TODO(daeyeon): Consider using C++ builtin to improve performance. | ||
| // Replace this when current v8 is updated to include the following commit: | ||
| // https://chromium.googlesource.com/v8/v8/+/9df5ef70ff18977b157028fc55ced5af4bcee535 |
There was a problem hiding this comment.
This commit seems trivial, why don't we just backport it now?
There was a problem hiding this comment.
Yes, that's better. I've opened #45474, and closing this pull request.
This was referenced Nov 16, 2022
|
Closing this due to PR #45512 |
This was referenced Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.