node-api: declare type napi_cleanup_hook #45391
Merged
+34
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
2368d67 to
952b7f7
Compare
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase.
952b7f7 to
43b8a91
Compare
NickNaso
approved these changes
Nov 9, 2022
daeyeon
approved these changes
Nov 9, 2022
19 tasks
19 tasks
This was referenced Nov 13, 2022
This was referenced Nov 15, 2022
This was referenced Nov 17, 2022
10 tasks
|
Landed in 62cde61 |
This was referenced Nov 20, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase. PR-URL: #45391 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
15 tasks
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Nov 23, 2022
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase. PR-URL: nodejs#45391 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase. PR-URL: #45391 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase. PR-URL: #45391 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase. PR-URL: #45391 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase. PR-URL: #45391 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
Declare type `napi_cleanup_hook` so that the function signature can be shared across the codebase. PR-URL: #45391 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare type
napi_cleanup_hookso that the function signature can beshared across the codebase.
This has no behavioral change. The type declaration can be available once
addons updated their node-api header files, e.g. with https://github.com/nodejs/node-api-headers.