8000 test: watch mode inspect restart repeatedly by MoLow · Pull Request #45060 · nodejs/node · GitHub 8000
[go: up one dir, main page]
Skip to content

test: watch mode inspect restart repeatedly #45060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 22, 2022
Merged

test: watch mode inspect restart repeatedly #45060

nodejs-github-bot merged 1 commit into from
Oct 22, 2022

Conversation

@MoLow
Copy link
Member
@MoLow MoLow commented Oct 18, 2022

Fixes: #44805

the timeout seems to occure when saving a single change of the file was not enough to trigger watch mode, so watch mode is triggerd repeatedly instead - until it succeeds to restart twice

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2022
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
@Trott
Copy link
Member
Trott commented Oct 19, 2022

Typo in commit: wath -> watch

@MoLow MoLow force-pushed the make-wath-mode-inspect-test-more-robust branch from 1b8dbee to 04d4df4 Compare October 19, 8000 2022 05:07
@Trott Trott changed the title test: wath mode inspect restart repeatedly test: watch mode inspect restart repeatedly Oct 19, 2022
@MoLow
Copy link
Member Author
MoLow commented Oct 20, 2022

Cc @nodejs/testing
If someone can review this it will be great

@MoLow MoLow added the review wanted PRs that need reviews. label Oct 20, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2022
@Trott
Copy link
Member
Trott commented Oct 20, 2022

@nodejs/fs

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Oct 20, 2022 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/47371/ 💚

This was referenced Oct 21, 2022
Open
Open
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2022
@nodejs-github-bot nodejs-github-bot merged commit 47b63f5 into nodejs:main Oct 22, 2022
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Oct 22, 2022

Landed in 47b63f5

@MoLow MoLow deleted the make-wath-mode-inspect-test-more-robust branch October 22, 2022 19:12
This was referenced Oct 23, 2022
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@MoLow @RafaelGSS
test: watch mode inspect restart repeatedly
9a146ba 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@MoLow @RafaelGSS
test: watch mode inspect restart repeatedly
2b3b291 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow @danielleadams
test: watch mode inspect restart repeatedly
35903e6 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow @danielleadams
test: watch mode inspect restart repeatedly
bdf7f25 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@MoLow @danielleadams
test: watch mode inspect restart repeatedly
a8030b9 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at leas 5B28 t one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests. watch-mode Issues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-watch-mode-inspect

5 participants

@MoLow @Trott @nodejs-github-bot @jasnell @benjamingr
0