node-api,test: fix test_reference_double_free crash #44927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
reviewed
Oct 9, 2022
test/js-native-api/test_reference_double_free/test_reference_double_free.c
Outdated
Show resolved
Hide resolved
Collaborator
Member
|
@nodejs/node-api please take a look, thank you |
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44927 ✔ Done loading data for nodejs/node/pull/44927 ----------------------------------- PR info ------------------------------------ Title node-api,test: fix test_reference_double_free crash (#44927) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch vmoroz:PR/Fix_test_reference_double_free -> nodejs:main Labels test, node-api, needs-ci Commits 2 - node-api,test: fix test_reference_double_free crash - return NULL instead of undefined Committers 1 - Vladimir Morozov PR-URL: https://github.com/nodejs/node/pull/44927 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44927 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 08 Oct 2022 20:39:41 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/44927#pullrequestreview-1135308312 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/44927#pullrequestreview-1142647651 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-14T15:54:17Z: https://ci.nodejs.org/job/node-test-pull-request/47273/ - Querying data for job/node-test-pull-request/47273/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 44927 From https://github.com/nodejs/node * branch refs/pull/44927/merge -> FETCH_HEAD ✔ Fetched commits as 1a8f8ba6c6ca..ba3a1e5b291f -------------------------------------------------------------------------------- [main db8a6f99c7] node-api,test: fix test_reference_double_free crash Author: Vladimir Morozov Date: Sat Oct 8 13:17:01 2022 -0700 1 file changed, 12 insertions(+), 9 deletions(-) [main 2ed8da8b5d] return NULL instead of undefined Author: Vladimir Morozov Date: Sat Oct 8 21:37:30 2022 -0700 1 file changed, 1 insertion(+), 3 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/3272013058 |
jasnell
approved these changes
Oct 18, 2022
Member
Author
I had changed my profile to make the primary e-mail public. I hope it should address the issue. |
legendecas
pushed a commit
that referenced
this pull request
Oct 19, 2022
PR-URL: #44927 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 5b316fe. Thank you for the work on this! |
Member
Author
Thank you for landing it! |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #44927 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #44927 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44927 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44927 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44927 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
The
js-native-api\test_reference_double_free\test_wrap.jstest always crashes when I use Visual Studio 2022.The cause of the crash is that the
deleteImmediatelyfunction callback is returning an invalidnapi_value.It happens because the
DeleteImmediatelyfunction that implements thedeleteImmediatelycallback returnsvoidinstead ofnapi_value. It causes it to return a random value kept inRAXregister - in my case it was0x40.The fix
The return type of the
DeleteImmediatelyfunction is changed tonapi_value.The related changes:
NODE_API_CALL_RETURN_VOIDtoNODE_API_CALLbecause we changed the return type.NODE_API_ASSERTto verify argument type - previously we retrieved the type, but never used it.NULLfrom the function.Notes
I did a quick search for
void.*napi_callback_infoin other tests to see if we have any other cases like this, but it found nothing.It seems that it is the only place where we have this issue.