doc: mention that http.Server inherits from net.Server #4455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe we can just drop the "This is an EventEmitter" part since the docs for This class inherits from |
cea2aa6 to
c69dd56
Compare
Contributor
Author
c69dd56 to
005a6f1
Compare
Contributor
|
LGTM. Can you update the commit message according to https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit. |
005a6f1 to
97117d0
Compare
Contributor
Author
|
Done. And thanks for the link. |
Contributor
|
LGTM |
3 similar comments
Contributor
|
LGTM |
Member
|
LGTM |
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Dec 30, 2015
PR-URL: #4455 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 4e8a005 |
Member
|
Thanks for the contribution @ryansobol! I believe this is your first commit to core and I see a few other PRs from you as well, it's great to see you jumping right in. Please holler if you need any help landing your other work. I hope you continue to find ways to contribute and stick around. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
PR-URL: nodejs#4455 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
PR-URL: #4455 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
PR-URL: #4455 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
PR-URL: nodejs#4455 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
PR-URL: nodejs#4455 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4455 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a Node beginner, it wasn't immediately obvious to me that
http.Serverinherits fromnet.Serveruntil I read the source.