doc: feature management proposal #41420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnb
reviewed
Jan 6, 2022
bnb
reviewed
Jan 6, 2022
bnb
reviewed
Jan 6, 2022
bnb
reviewed
Jan 6, 2022
bnb
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
VoltrexKeyva
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
mscdex
reviewed
Jan 6, 2022
Member
|
If we're going to add a doc like this, we'll probably want to include a link to it in https://github.com/nodejs/node/blob/master/.github/ISSUE_TEMPLATE/2-feature-request.yml. |
mhdawson
commented
Jan 7, 2022
aduh95
reviewed
Jan 7, 2022
jasnell
reviewed
Jan 17, 2022
|
|
||
| ## Automated feature request handling | ||
|
|
||
| Our experience is that most feature requests that are |
Member
There was a problem hiding this comment.
Why are these line lengths so short? :-P
Member
Author
There was a problem hiding this comment.
I prefer that to having to check each one for being too long :)
jasnell
approved these changes
Jan 17, 2022
Contributor
|
Should this be moved to |
Member
Author
|
@Mesteery not that the other PR has landed this does need a "rebase" |
Refs: https://github.com/nodejs/node/discussions/40823 Refs: nodejs#41113 Signed-off-by: Michael Dawson <mdawson@devrus.com>
Member
Author
|
@Mesteery moved. |
Member
Author
|
@targos just wondering if you'd had a chance to consider what updates we might make to this in order to incorporate your suggestion about using Node.js feature requests |
Member
|
@mhdawson I think this PR doesn't have to wait for this project. I'm convinced that it will be useful but I need to discuss with other people before documenting it. |
Member
Author
|
@targos thanks. @nodejs/tsc it would be good to have a few more approvals since once this lands I'll work to turn on stale bot and we'll have some issues tagged feature being closed as outline in the process. |
aduh95
approved these changes
Jan 31, 2022
mmarchini
approved these changes
Feb 1, 2022
Trott
reviewed
Feb 1, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Darshan Sen <raisinten@gmail.com>
Co-authored-by: Darshan Sen <raisinten@gmail.com>
Member
Author
|
Agreed in last weeks TSC meeting on actions, does still need to be on agenda? - Wrong PR |
gireeshpunathil
approved these changes
Feb 3, 2022
mhdawson
added a commit
that referenced
this pull request
Feb 4, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: #41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
Author
|
Landed in 6c0eb94 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: #41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: #41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: #41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: nodejs#41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: nodejs#41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 8, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: #41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Refs: https://github.com/nodejs/node/discussions/40823 Refs: #41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113
Signed-off-by: Michael Dawson mdawson@devrus.com