8000 util: make sure error causes of any type may be inspected by BridgeAR · Pull Request #41097 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

util: make sure error causes of any type may be inspected #41097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BridgeAR wants to merge 2 commits into from
Closed

util: make sure error causes of any type may be inspected #41097

BridgeAR wants to merge 2 commits into from

Conversation

@BridgeAR
Copy link
Member
@BridgeAR BridgeAR commented Dec 6, 2021

An error cause may be of any type. Handle all of them, no matter
if they are an error or not.

Fixes: #41096

Signed-off-by: Ruben Bridgewater ruben@bridgewater.de

@BridgeAR BridgeAR requested a review from targos December 6, 2021 13:34
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Dec 6, 2021
@targos
Copy link
Member
targos commented Dec 6, 2021

I also found that falsy causes are not inspected, but that can be fixed in a separate PR.

@BridgeAR
Copy link
Member Author
BridgeAR commented Dec 6, 2021

@targos how would you handle undefined and null? I would at least skip those?

@targos
Copy link
Member
targos commented Dec 6, 2021

I would always inspect if Object.hasOwn(err, 'cause') === true with no exception.

@BridgeAR
Copy link
Member Author
BridgeAR commented Dec 6, 2021

@targos I added another commit to also inspect falsy values besides undefined. Undefined is used in argument default values as "does not exist" and I would handle it here identically.

@BridgeAR
util: make sure error causes of any type may be inspected
cd03389 
An error cause may be of any type. Handle all of them, no matter
if they are an error or not.

Fixes: nodejs#41096

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
util: serialize falsy cause values while inspecting errors
38fc7f8 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>