8000 [v14.x] deps: update to cjs-module-lexer@1.1.1 by guybedford · Pull Request #38002 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

[v14.x] deps: update to cjs-module-lexer@1.1.1 #38002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guybedford wants to merge 1 commit into from
Closed

[v14.x] deps: update to cjs-module-lexer@1.1.1 #38002

guybedford wants to merge 1 commit into from

Conversation

@guybedford
Copy link
Contributor
@guybedford guybedford commented Mar 31, 2021

This backports the cjs-module-lexer update from #37992 for 14.x.

Note this branch didn't get the 1.1.0 update yet, so this handles the full upgrade path.

@nodejs/modules

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v14.x labels Mar 31, 2021
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Mar 31, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37071/

@guybedford guybedford force-pushed the cjs-module-lexer-update-14 branch from 884fc07 to efcad79 Compare April 8, 2021 14:34
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Apr 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37300/

MylesBorins
MylesBorins approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor
@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@guybedford guybedford changed the base branch from v14.x-staging to v14.x April 8, 2021 22:48
@guybedford guybedford changed the base branch from v14.x to v14.x-staging April 8, 2021 22:53
guybedford added a commit that referenced this pull request Apr 14, 2021
@guybedford
deps: update to cjs-module-lexer@1.1.1
d56079a 
PR-URL: #38002
Backport-PR-URL: #37992
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@guybedford
Copy link
Contributor Author
guybedford commented Apr 14, 2021

Landed in d56079a.

@guybedford guybedford closed this Apr 14, 2021
This was referenced Apr 27, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hybrist hybrist hybrist approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guybedford @nodejs-github-bot @MylesBorins @hybrist
0