8000 tools: fix d8 macOS build by targos · Pull Request #37211 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

tools: fix d8 macOS build #37211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 1 commit into from
+0 −11
Closed

tools: fix d8 macOS build #37211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tools/v8_gypfiles/d8.gyp
View file
Open in desktop
6493
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,6 @@
[ 'OS=="win"', {
'sources': [ '<(V8_ROOT)/src/d8/d8-windows.cc', ]
}],
[ 'component!="shared_library"', {
'conditions': [
[ 'v8_postmortem_support==1', {
'xcode_settings': {
'OTHER_LDFLAGS': [
'-Wl,-force_load,<(PRODUCT_DIR)/libv8_base.a'
],
},
}],
],
}],
['v8_enable_i18n_support==1', {
'dependencies': [
'<(icu_gyp_path):icui18n',
Expand Down
0