timers: reject with AbortError on cancellation #36317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Nov 29, 2020
jasnell
approved these changes
Nov 29, 2020
Collaborator
ronag
approved these changes
Nov 29, 2020
ronag
approved these changes
Nov 29, 2020
Collaborator
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36317 ✔ Done loading data for nodejs/node/pull/36317 ----------------------------------- PR info ------------------------------------ Title timers: reject with AbortError on cancellation (#36317) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch benjamingr:timers-promises-dom-exception -> nodejs:master Labels promises, timers Commits 1 - timers: reject with AbortError on cancellation Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/36317 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36317 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-30T09:05:21Z: https://ci.nodejs.org/job/node-test-pull-request/34624/ - Querying data for job/node-test-pull-request/34624/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sun, 29 Nov 2020 18:04:46 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36317#pullrequestreview-540503231 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36317#pullrequestreview-540503892 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36317#pullrequestreview-540505016 ✔ - Robert Nagy (@ronag): https://github.com/nodejs/node/pull/36317#pullrequestreview-540511194 ✖ This PR needs to wait 28 more minutes to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/394367476 |
Contributor
|
Landed in 780fcb4...1ed72f6 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 1, 2020
PR-URL: #36317 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36317 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
PR-URL: nodejs#36317 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
targos
added a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36317 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36317 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the consensus from the AbortSignal behaviour meeting (at #36084 )
This replaces the DOMException timers/promises reject with with a Node AbortError (like HTTP/HTTP2 and streams)
From a user point of view it has the same
.nameand.codebut is easier to shim, even the docs and tests don't need to change :]cc @mcollina @jasnell @ronag
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes