8000 doc: move v8.getHeapCodeStatistics() by Trott · Pull Request #36027 · nodejs/node · GitHub
  • [go: up one dir, main page]

    Skip to content

    Conversation

    @Trott
    Copy link
    Member
    @Trott Trott commented Nov 7, 2020

    Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
    An effort to alphabetize all the entries met some resistance on the
    grounds that it put some things in an order that wasn't logical, but
    this one should be uncontroversial, I think.

    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • documentation is changed or added
    • commit message follows commit guidelines

    @nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2020
    @aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2020
    @github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2020
    Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
    An effort to alphabetize all the entries met some resistance on the
    grounds that it put some things in an order that wasn't logical, but
    this one should be uncontroversial, I think.
    
    PR-URL: nodejs#36027
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @Trott
    Copy link
    Member Author
    Trott commented Nov 10, 2020

    Landed in 270a02c

    @Trott Trott merged commit 270a02c into nodejs:master Nov 10, 2020
    @Trott Trott deleted the v8-partial-alpha branch November 10, 2020 13:30
    danielleadams pushed a commit that referenced this pull request Nov 10, 2020
    Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
    An effort to alphabetize all the entries met some resistance on the
    grounds that it put some things in an order that wasn't logical, but
    this one should be uncontroversial, I think.
    
    PR-URL: #36027
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @danielleadams danielleadams mentioned this pull request Nov 10, 2020
    BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
    Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
    An effort to alphabetize all the entries met some resistance on the
    grounds that it put some things in an order that wasn't logical, but
    this one should be uncontroversial, I think.
    
    PR-URL: #36027
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
    Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
    An effort to alphabetize all the entries met some resistance on the
    grounds that it put some things in an order that wasn't logical, but
    this one should be uncontroversial, I think.
    
    PR-URL: #36027
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
    BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
    Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
    An effort to alphabetize all the entries met some resistance on the
    grounds that it put some things in an order that wasn't logical, but
    this one should be uncontroversial, I think.
    
    PR-URL: #36027
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    0