8000 [v14.x backport] doc: revise introductory child_process text by Trott · Pull Request #35420 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

[v14.x backport] doc: revise introductory child_process text #35420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

[v14.x backport] doc: revise introductory child_process text #35420

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member
@Trott Trott commented Sep 29, 2020

This consolidates information about Windows environment variables and
has a few other smaller improvements (punctuation, present tense, etc.).

PR-URL: #35344
Reviewed-By: Daijiro Wachi daijiro.wachi@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

Checklist

@Trott
doc: revise introductory child_process text
2dbcc34 
This consolidates information about Windows environment variables and
has a few other smaller improvements (punctuation, present tense, etc.).

PR-URL: nodejs#35344
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. v14.x labels Sep 29, 2020
@Trott Trott mentioned this pull request Sep 29, 2020
Merged
2 tasks
@danielleadams
Copy link
Contributor
danielleadams commented Oct 6, 2020

Landed in 84b433b73ee2

danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@Trott @danielleadams
doc: revise introductory child_process text
a995dd7 
This consolidates information about Windows environment variables and
has a few other smaller improvements (punctuation, present tense, etc.).

PR-URL: #35344
Backport-PR-URL: #35420
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the backport35344 branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

+1 more reviewer

@danielleadams danielleadams danielleadams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott @danielleadams @BethGriggs @nodejs-github-bot
0