timers: allow promisified timeouts/immediates to be canceled #33833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I like this. However I think it's time we design a few new apis for I do On a technical side this would have the benefit of avoiding to call |
Member
Author
|
I've been considered exporting the promisified versions of const {
setTimeout,
setImmediate
} = require('timers/promises');I'm also considering a promisified version of const {
setInterval,
} = require('timers/promises');
(async () => {
for await (const n of setInterval(1000)) {
console.log('tick...')
}
})()We also need to consider how to ref/unref promisified timers/intervals/immediates. |
addaleax
reviewed
Jun 11, 2020
60ee29c to
129a5c2
Compare
Member
Author
|
@mcollina ... I will introduce |
Collaborator
devsnek
reviewed
Jun 16, 2020
Using the new experimental AbortController... Signed-off-by: James M Snell <jasnell@gmail.com>
28e3e65 to
b2e0153
Compare
Collaborator
Collaborator
devsnek
approved these changes
Jun 18, 2020
jasnell
added a commit
that referenced
this pull request
Jun 18, 2020
Using the new experimental AbortController... Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33833 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Member
Author
|
Landed in bfbdc84 |
36 tasks
4 tasks
This was referenced Jun 20, 2020
Member
|
Marking |
29 tasks
3 tasks
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 24, 2021
Using the new experimental AbortController... Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#33833 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 26, 2021
Using the new experimental AbortController... Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#33833 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
Using the new experimental AbortController... Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#33833 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new experimental AbortController...
This will necessarily be experimental for as long as
AbortControlleris experimental.Signed-off-by: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes