8000 doc: removed unnecessary util imports from vm examples by WalasPrime · Pull Request #33179 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

doc: removed unnecessary util imports from vm examples #33179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WalasPrime wants to merge 1 commit into from
Closed

doc: removed unnecessary util imports from vm examples #33179

WalasPrime wants to merge 1 commit into from

Conversation

@WalasPrime
Copy link
Contributor
@WalasPrime WalasPrime commented Apr 30, 2020

Just noticed that VM examples all declare const util = require('util') but never use them 🤷‍♂️

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Apr 30, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2020
@addaleax
Copy link
Member
addaleax commented May 7, 2020

Landed in d6b19fd

addaleax pushed a commit that referenced this pull request May 7, 2020
@WalasPrime @addaleax
doc: removed unnecessary util imports from vm examples
d6b19fd 
PR-URL: #33179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax addaleax closed this May 7, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
@WalasPrime @codebytere
doc: removed unnecessary util imports from vm examples
b5dcfbf 
PR-URL: #33179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@WalasPrime @codebytere
doc: removed unnecessary util imports from vm examples
0cee4c3 
PR-URL: #33179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@rexagod rexagod rexagod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@WalasPrime @addaleax @jasnell @BridgeAR @rexagod @nodejs-github-bot
0