8000 util: improve prototype inspection using `inspect()` and `showHidden` by BridgeAR · Pull Request #31113 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

util: improve prototype inspection using inspect() and showHidden #31113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BridgeAR wants to merge 1 commit into from
Closed

util: improve prototype inspection using inspect() and showHidden #31113

BridgeAR wants to merge 1 commit into from

Conversation

@BridgeAR
Copy link
Member
@BridgeAR BridgeAR commented Dec 27, 2019 •
edited
Loading

The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 27, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeAR
util: improve prototype inspection using inspect() and showHidden
5546d95 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.
@BridgeAR BridgeAR force-pushed the 2019-12-27-fix-inspect-prototype branch from f6bbe0f to 5546d95 Compare December 31, 2019 15:08
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 31, 2019
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Dec 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/28050/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Jan 1, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28062/

@Trott
Copy link
Member
Trott commented Jan 1, 2020 •
edited by BridgeAR
Loading

CITGM out of caution: https://ci.nodejs.org/job/citgm-smoker/2177/ ✅
8000

BridgeAR added a commit that referenced this pull request Jan 2, 2020
@BridgeAR
util: improve prototype inspection using inspect() and showHidden
7babffb 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR
Copy link
Member Author
BridgeAR commented Jan 2, 2020

Landed in 7babffb 🎉

@BridgeAR BridgeAR closed this Jan 2, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
@BridgeAR
util: improve prototype inspection using inspect() and showHidden
697908e 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
@targos
Copy link
Member
targos commented Jan 14, 2020

@BridgeAR BridgeAR deleted the 2019-12-27-fix-inspect-prototype branch January 20, 2020 12:09
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 22, 2020
@BridgeAR
util: improve prototype inspection using inspect() and showHidden
9c9b338 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

PR-URL: nodejs#31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 22, 2020
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Jan 30, 2020
@BridgeAR @MylesBorins
util: improve prototype inspection using inspect() and showHidden
fc0febe 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

Backport-PR-URL: #31431
PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 30, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@BridgeAR @BethGriggs
util: improve prototype inspection using inspect() and showHidden
a1d36db 
The fast path for the prototype inspection had a bug that caused some
prototype properties to be skipped that should in fact be inspected.

Backport-PR-URL: #31431
PR-URL: #31113
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BridgeAR @nodejs-github-bot @Trott @targos @jasnell @MylesBorins
0

This needs a backport or other previous PRs to be backported in order to land on v12.x-staging.