8000 tools: enforce blank line between functions by Trott · Pull Request #30696 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    tools: enforce blank line between functions #30696

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Merged
    Trott merged 0 commits into from
    Nov 30, 2019
    Merged

    tools: enforce blank line between functions #30696

    Trott merged 0 commits into from
    Nov 30, 2019
    +0 −0

    Conversation

    @Trott
    Copy link
    Member
    @Trott Trott commented Nov 28, 2019

    Refs: #21128 (comment)

    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • documentation is changed or added
    • commit message follows commit guidelines

    @nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 28, 2019
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Nov 28, 2019

    CI: https://ci.nodejs.org/job/node-test-pull-request/27130/

    @Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2019
    @nodejs-github-bot

    This comment has been minimized.

    Sign in to view
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Nov 29, 2019 •
    edited by Trott
    Loading

    CI: https://ci.nodejs.org/job/node-test-pull-request/27153/ ✅

    @Trott
    Copy link
    Member Author
    Trott commented Nov 30, 2019

    Landed in 2070d3f...68abaab

    Trott added a commit to Trott/io.js that referenced this pull request Nov 30, 2019
    @Trott
    benchmark,doc,lib,test: prepare for padding lint rule
    359766b 
    Upcoming lint rule will require a blank line between consecutive
functions. Add it in the places where we don't have it already.

PR-URL: nodejs#30696
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott Trott closed this Nov 30, 2019
    @Trott Trott deleted the padding branch November 30, 2019 14:30
    @Trott Trott merged commit 68abaab into nodejs:master Nov 30, 2019
    targos pushed a commit that referenced this pull request Dec 1, 2019
    @Trott @targos
    benchmark,doc,lib,test: prepare for padding lint rule
    4cd4e7c 
    Upcoming lint rule will require a blank line between consecutive
functions. Add it in the places where we don't have it already.

PR-URL: #30696
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos pushed a commit that referenced this pull request Dec 1, 2019
    @Trott @targos
    tools: enforce blank line between functions
    941a91d
    8000 
    Refs: #21128 (comment)

PR-URL: #30696
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
    Merged
    targos pushed a commit that referenced this pull request Dec 5, 2019
    @Trott @targos
    benchmark,doc,lib,test: prepare for padding lint rule
    3e58871 
    Upcoming lint rule will require a blank line between consecutive
functions. Add it in the places where we don't have it already.

PR-URL: #30696
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos pushed a commit that referenced this pull request Dec 5, 2019
    @Trott @targos
    tools: enforce blank line between functions
    81712c9 
    Refs: #21128 (comment)

PR-URL: #30696
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
    Closed
    MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
    @Trott @MylesBorins
    benchmark,doc,lib,test: prepare for padding lint rule
    da0c673 
    Upcoming lint rule will require a blank line between consecutive
functions. Add it in the places where we don't have it already.

PR-URL: #30696
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
    @Trott @MylesBorins
    tools: enforce blank line between functions
    a715c25 
    Refs: #21128 (comment)

PR-URL: #30696
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
R
8000
eviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @addaleax addaleax addaleax approved these changes

    @lpinca lpinca lpinca approved these changes

    @targos targos targos approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    @richardlau richardlau richardlau approved these changes

    @gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

    @trivikr trivikr trivikr approved these changes

    +2 more reviewers

    @devsnek devsnek devsnek approved these changes

    @lundibundi lundibundi lundibundi approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.
    0