build,win: fix node.exe resource version #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/373/ Also tested locally with both VS2013 and VS2015. |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: nodejs#2963 PR-URL: nodejs#3053 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9d5ceec to
a6aab43
Compare
rvagg
pushed a commit
to rvagg/io.js
that referenced
this pull request
Dec 3, 2015
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: nodejs#2963 PR-URL: nodejs#3053 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Apr 1, 2016
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: nodejs/node#2963 PR-URL: nodejs/node#3053 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: nodejs/node#2963 PR-URL: nodejs/node#3053 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was described in #2963 , the resource file was not being compiled correctly and the version information in the details of
node.exewas wrong.Simply removing the quotes from
node.rcsolves this for releases and-prebuilds, but does not work for nightlies and rcs, that requirerc.exeto receive theNODE_TAGas a preprocessor definition.When MSBuild invokes
rc.exe, it passesNODE_TAGunstringified, but passes it correctly tocl.exe. Hence, this workaround was made to apply only to the resource file.cc @nodejs/platform-windows