8000 doc: add Bethany to TSC by mhdawson · Pull Request #29546 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

doc: add Bethany to TSC #29546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhdawson wants to merge 2 commits into from
Closed

doc: add Bethany to TSC #29546

mhdawson wants to merge 2 commits into from

Conversation

@mhdawson
Copy link
Member
@mhdawson mhdawson commented Sep 13, 2019 •
edited
Loading

Refs: nodejs/TSC#718

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 13, 2019
@mhdawson
Copy link
Member Author
mhdawson commented Sep 13, 2019

Should land after: #29545

@mhdawson
Copy link
Member Author
mhdawson commented Sep 13, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3905/

@mhdawson
Copy link
Member Author
mhdawson commented Sep 13, 2019

new lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3908/

@mhdawson mhdawson mentioned this pull request Sep 13, 2019
Closed
@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 13, 2019
@mhdawson
Copy link
Member Author
mhdawson commented Sep 13, 2019

Added fast track please upvote.

mhdawson added a commit that referenced this pull request Sep 13, 2019
@mhdawson
doc: add Bethany to TSC
dff22dd 
Refs: nodejs/TSC#718

PR-URL: #29546
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@mhdawson
Copy link
Member Author
mhdawson commented Sep 13, 2019 •
edited by tniessen
Loading

@mhdawson mhdawson closed this Sep 13, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
@mhdawson @targos
doc: add Bethany to TSC
5a25f97 
Refs: nodejs/TSC#718

PR-URL: #29546
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@mhdawson @BridgeAR
doc: add Bethany to TSC
ca8e87a 
Refs: nodejs/TSC#718

PR-URL: #29546
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@mhdawson mhdawson deleted the addBethany branch September 14, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mhdawson @addaleax @lpinca @targos @cjihrig @tniessen @richardlau @gireeshpunathil @nodejs-github-bot
0

Landed in dff22dd