doc: describe NODE_OPTIONS interop w/cmd line opts #28928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Aug 1, 2019
silverwind
approved these changes
Aug 1, 2019
Trott
reviewed
Aug 2, 2019
doc/api/cli.md
Outdated
Member
There was a problem hiding this comment.
Optional nit: No need for emphasis?
Suggested change
| A singleton flag passed as a command line option will *override* the same flag | |
| A singleton flag passed as a command line option will override the same flag |
Contributor
Author
There was a problem hiding this comment.
Removed the emphasis, but left singleton in -- happy to follow what you think on that, I think that it can work either way.
Member
There was a problem hiding this comment.
Yeah, I changed my mind and decided singleton was fine. If there's a better word, it can always be updated in a subsequent PR.
Member
Trott
approved these changes
Aug 2, 2019
9e22ee2 to
6ae4a8f
Compare
6ae4a8f to
135407e
Compare
Member
cjihrig
approved these changes
Aug 3, 2019
Member
|
Landed in 5eaef7b |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 4, 2019
Fixes nodejs#28910 PR-URL: nodejs#28928 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make lintpassesDisambiguates the description of NODE_OPTIONS wrt how it is overrides/compounded by command line options. Adds examples of singleton and multi flags.
Fixes #28910