8000 finish test coverage for lib/internal/dns/utils.js by Trott · Pull Request #27006 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

finish test coverage for lib/internal/dns/utils.js #27006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 2 commits into from
Closed

finish test coverage for lib/internal/dns/utils.js #27006

Trott wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member
@Trott Trott commented Mar 30, 2019

Add coverage to achieve 100% code coverage in tests for lib/internal/dns/utils.js.

First commit:

dns: refactor lib/internal/dns/utils.js

* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

Second commit:

test: add IPv6 brackets but no port to test-dns

Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added 2 commits March 29, 2019 21:33
@Trott
dns: refactor lib/internal/dns/utils.js
caedd72 
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity
@Trott
test: add IPv6 brackets but no port to test-dns
2e4719f 
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Mar 30, 2019

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3101/pipeline

@nodejs-github-bot nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label Mar 30, 2019
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Mar 30, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22027/

@Trott Trott changed the title Ref dns utils finish test coverage for lib/internal/dns/utils.js Mar 30, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2019
@Trott
Copy link
Member Author
Trott commented Apr 1, 2019

Landed in c6faf5b...8afab1a

@Trott Trott closed this Apr 1, 2019
Trott added a commit to Trott/io.js that referenced this pull request Apr 1, 2019
@Trott
dns: refactor lib/internal/dns/utils.js
c88d957 
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: nodejs#27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Apr 1, 2019
@Trott
test: add IPv6 brackets but no port to test-dns
8afab1a 
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: nodejs#27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@Trott @BethGriggs
dns: refactor lib/internal/dns/utils.js
08c93cd 
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@Trott @BethGriggs
test: add IPv6 brackets but no port to test-dns
f317ed3 
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@Trott @BethGriggs
dns: refactor lib/internal/dns/utils.js
fdd466b 
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@Trott @BethGriggs
test: add IPv6 brackets but no port to test-dns
df6c018 
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@Trott @BethGriggs
dns: refactor lib/internal/dns/utils.js
af3ce38 
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@Trott @BethGriggs
test: add IPv6 brackets but no port to test-dns
35119d6 
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@Trott @BethGriggs
dns: refactor lib/internal/dns/utils.js
96e429a 
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@Trott @BethGriggs
test: add IPv6 brackets but no port to test-dns
a0b0e42 
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@Trott Trott deleted the ref-dns-utils branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned
< 5299 /div>

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dns Issues and PRs related to the dns subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott @nodejs-github-bot @cjihrig @BridgeAR
0