8000 test: strengthen test-worker-prof by gireeshpunathil · Pull Request #26608 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

test: strengthen test-worker-prof #26608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gireeshpunathil merged 1 commit into from
Mar 24, 2019
Merged

test: strengthen test-worker-prof #26608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
< 8000 div class="select-menu-blankslate select-menu-error"> Failed to load files.
Loading
Diff view
Diff view
86 changes: 62 additions & 24 deletions test/parallel/test-worker-prof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,78 @@
'use strict';
require('../common');
const common = require('../common');
const tmpdir = require('../common/tmpdir');
const fs = require('fs');
const assert = require('assert');
const util = require('util');
const { join } = require('path');
const { spawnSync } = require('child_process');
const { Worker } = require('worker_threads');

// Test that --prof also tracks Worker threads.
// Refs: https://github.com/nodejs/node/issues/24016

if (process.argv[2] === 'child') {
const spin = `
const start = Date.now();
while (Date.now() - start < 1000);
let files = fs.readdirSync(tmpdir.path);
const plog = files.filter((name) => /\.log$/.test(name))[0];
if (plog === undefined) {
console.error('`--prof` did not produce a profile log for parent thread!');
process.exit(1);
}
const pingpong = `
let counter = 0;
const { Worker, parentPort } = require('worker_threads');
parentPort.on('message', (m) => {
if (counter++ === 1024)
process.exit(0);
parentPort.postMessage(
m.toString().split('').reverse().toString().replace(/,/g, ''));
});
`;
new Worker(spin, { eval: true });
eval(spin);
return;
}

tmpdir.refresh();
spawnSync(process.execPath, ['--prof', __filename, 'child'],
{ cwd: tmpdir.path });
const files = fs.readdirSync(tmpdir.path);
const logfiles = files.filter((name) => /\.log$/.test(name));
assert.strictEqual(logfiles.length, 2); // Parent thread + child thread.
const { Worker } = require('worker_threads');
const data = 'x'.repeat(1024);
const w = new Worker(pingpong, { eval: true });
w.on('message', (m) => {
w.postMessage(m.toString().split('').reverse().toString().replace(/,/g, ''));
});

w.on('exit', common.mustCall(() => {
files = fs.readdirSync(tmpdir.path);
const wlog = files.filter((name) => /\.log$/.test(name) && name !== plog)[0];
if (wlog === undefined) {
console.error('`--prof` did not produce a profile log' +
' for worker thread!');
process.exit(1);
}
process.exit(0);
}));
w.postMessage(data);
} else {
tmpdir.refresh();
Copy link
Member
@Trott Trott Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An absolute micronit here but maybe add a comment above this (right below the else line) saying this is the parent process?

const spawnResult = spawnSync(
process.execPath, ['--prof', __filename, 'child'],
{ cwd: tmpdir.path, encoding: 'utf8' });
assert.strictEqual(spawnResult.stderr.toString(), '',
`child exited with an error: \
${util.inspect(spawnResult)}`);
assert.strictEqual(spawnResult.signal, null,
`child exited with signal: ${util.inspect(spawnResult)}`);
assert.strictEqual(spawnResult.status, 0,
`child exited with non-zero status: \
${util.inspect(spawnResult)}`);
const files = fs.readdirSync(tmpdir.path);
const logfiles = files.filter((name) => /\.log$/.test(name));
assert.strictEqual(logfiles.length, 2); // Parent thread + child thread.

for (const logfile of logfiles) {
const lines = fs.readFileSync(join(tmpdir.path, logfile), 'utf8').split('\n');
const ticks = lines.filter((line) => /^tick,/.test(line)).length;
for (const logfile of logfiles) {
const lines = fs.readFileSync(
join(tmpdir.path, logfile), 'utf8').split('\n');
const ticks = lines.filter((line) => /^tick,/.test(line)).length;

// Test that at least 15 ticks have been recorded for both parent and child
// threads. When not tracking Worker threads, only 1 or 2 ticks would
// have been recorded.
// When running locally on x64 Linux, this number is usually at least 700
// for both threads, so 15 seems like a very safe threshold.
assert(ticks >= 15, `${ticks} >= 15`);
// Test that at least 15 ticks have been recorded for both parent and child
// threads. When not tracking Worker threads, only 1 or 2 ticks would
// have been recorded.
// When running locally on x64 Linux, this number is usually at least 200
// for both threads, so 15 seems like a very safe threshold.
assert(ticks >= 15, `${ticks} >= 15`);
}
}
0