deps: remove OpenSSL git and travis configuration #25689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
span aria-label="This line has hidden Unicode characters" data-view-component="true" class="line-alert tooltipped tooltipped-e">
OpenSSL is packaging its git and travis configuration files. Remove them, Node.js has its own.
Contributor
Author
|
@shigeki Perhaps these files do no harm, but it seems strange to have them in our source, and existi 8000 ng Makefile already deleted one of the git files. What do you think? |
Contributor
Author
|
@danbev @rvagg @MylesBorins @shigeki, you've done openssl upgrades, what do you think? If no one cares, I'll close this, but it seems odd to me to have openssl's .git and .travis files in our deps tree. /cc @nodejs/crypto |
danbev
approved these changes
Feb 2, 2019
tniessen
approved these changes
Feb 2, 2019
ryzokuken
approved these changes
Feb 2, 2019
Contributor
Author
|
Landed in f395a4a |
pull bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
Feb 4, 2019
OpenSSL is packaging its git and travis configuration files. Remove them, Node.js has its own. PR-URL: nodejs#25689 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
OpenSSL is packaging its git and travis configuration files. Remove them, Node.js has its own. PR-URL: #25689 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL is packaging its git and travis configuration files. Remove
them, Node.js has its own.
This will remove .gitmodules, .gitattributes, .travis.yml, .travis-create-release.sh, .travis-apt-pin.preference from being present in https://github.com/nodejs/node/tree/master/deps/openssl/openssl
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes