8000 lib: simplify own keys retrieval by vsemozhetbyt · Pull Request #24582 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    lib: simplify own keys retrieval #24582

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    vsemozhetbyt wants to merge 1 commit into from
    Closed

    lib: simplify own keys retrieval #24582

    vsemozhetbyt wants to merge 1 commit into from

    Conversation

    @vsemozhetbyt
    Copy link
    Contributor
    @vsemozhetbyt vsemozhetbyt commented Nov 23, 2018
    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • commit message follows commit guidelines

    This replacement can save us a function call, two array spreadings, and an array concatenation.

    Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description

    @vsemozhetbyt
    lib: simplify own keys retrieval
    46a6915 
    This replacement can save us a function call, two array spreadings,
and an array concatenation.

Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Nov 23, 2018

    @vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1685/pipeline

    @vsemozhetbyt vsemozhetbyt added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 23, 2018
    @vsemozhetbyt
    Copy link
    Contributor Author
    vsemozhetbyt commented Nov 23, 2018

    Full CI: https://ci.nodejs.org/job/node-test-pull-request/18904/

    @vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2018
    @vsemozhetbyt
    Copy link
    Contributor Author
    vsemozhetbyt commented Nov 24, 2018

    Rebuild failed jobs:
    https://ci.nodejs.org/job/node-test-commit-freebsd/22236/
    https://ci.nodejs.org/job/node-test-commit-windows-fanned/22666/

    @vsemozhetbyt
    Copy link
    Contributor Author
    vsemozhetbyt commented Nov 25, 2018

    Landed in f2432a4
    Thank you for the reviews.

    @vsemozhetbyt vsemozhetbyt deleted the lib-internal-safe_globals.js branch November 25, 2018 23:33
    vsemozhetbyt added a commit that referenced this pull request Nov 25, 2018
    @vsemozhetbyt
    lib: simplify own keys retrieval
    f2432a4 
    This replacement can save us a function call, two array spreadings,
and an array concatenation.

PR-URL: #24582
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos pushed a commit that referenced this pull request Nov 27, 2018
    @vsemozhetbyt @targos
    lib: simplify own keys retrieval
    b99e355 
    This replacement can save us a function call, two array spreadings,
and an array concatenation.

PR-URL: #24582
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    rvagg pushed a commit that referenced this pull request Nov 28, 2018
    @vsemozhetbyt @rvagg
    lib: simplify own keys retrieval
    b2c243f 
    This replacement can save us a function call, two array spreadings,
and an array concatenation.

PR-URL: #24582
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
    Merged
    4 tasks
    This was referenced Dec 7, 2018
    Closed
    Closed
    Closed
    Closed
    Closed
    refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
    @vsemozhetbyt @refack
    lib: simplify own keys retrieval
    874e34f 
    This replacement can save us a function call, two array spreadings,
and an array concatenation.

PR-URL: nodejs#24582
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
    @vsemozhetbyt @BethGriggs
    lib: simplify own keys retrieval
    ce2aa80 
    This replacement can save us a function call, two array spreadings,
and an array concatenation.

PR-URL: #24582
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
    Merged
    rvagg pushed a commit that referenced this pull request Feb 28, 2019
    @vsemozhetbyt @rvagg
    lib: simplify own keys retrieval
    2a1e768 
    This replacement can save us a function call, two array spreadings,
and an array concatenation.

PR-URL: #24582
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @addaleax addaleax addaleax approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    +1 more reviewer

    @devsnek devsnek devsnek approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    524F author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    6 participants

    @vsemozhetbyt @nodejs-github-bot @addaleax @cjihrig @devsnek @BethGriggs
    0