test: improve test-gc-http-client-connaborted #23193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 1, 2018
8000
joyeecheung
approved these changes
Oct 1, 2018
BridgeAR
approved these changes
Oct 1, 2018
lpinca
approved these changes
Oct 1, 2018
Member
Author
|
Ok, this test as failed on windows on CI. Even though this (IMO) is an improvement it's still not enough. I think we can land this anyway as it should at least decrease the rate at which we are getting failures. |
Member
I think that might help with masking a real problem, see nodejs/reliability#18 (comment). |
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests
2ea292f to
67771e9
Compare
Member
Author
thefourtheye
approved these changes
Oct 9, 2018
Member
|
Landed in 63a6352 |
addaleax
pushed a commit
that referenced
this pull request
Oct 12, 2018
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: #23193 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Trott
pushed a commit
that referenced
this pull request
Oct 13, 2018
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: #23193 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2018
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: #23193 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: #23193 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: #23193 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: #23193 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: #23193 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis has been failing a lot recently so tried to make this less intensive, refactor a bit. With this, I was able to run this with '-j 32 --repeat 1920' in 'test/parallel' on 4 core (8 thread) i7.