8000 src: fix a typo in the comment by gireeshpunathil · Pull Request #23078 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

src: fix a typo in the comment #23078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gireeshpunathil wants to merge 1 commit into from
Closed

src: fix a typo in the comment #23078

gireeshpunathil wants to merge 1 commit into from

Conversation

@gireeshpunathil
Copy link
Member
@gireeshpunathil gireeshpunathil commented Sep 25, 2018

withing -> within

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Sep 25, 2018

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1008/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 25, 2018
@vsemozhetbyt
Copy link
Contributor
vsemozhetbyt commented Sep 25, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2018
@addaleax
Copy link
Member
addaleax commented Sep 25, 2018

Landed in 3ea0588 :)

@addaleax addaleax closed this Sep 25, 2018
addaleax pushed a commit that referenced this pull request Sep 25, 2018
@gireeshpunathil @addaleax
src: fix a typo in the comment
3ea0588 
withing -> within

PR-URL: #23078
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos pushed a commit that referenced this pull request Sep 27, 2018
@gireeshpunathil @targos
src: fix a typo in the comment
4d61c34 
withing -> within

PR-URL: #23078
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed