child_process: handling fork( path, undefined / null, obj ) #22416
Conversation
daf1bd3 to
4ffbf08
Compare
|
@jasnell A CITGM run is required. |
|
Ping @jasnell. |
|
Related failure: |
|
@lundibundi Need some help fixing the failure that you've mentioned. Cannot reproduce in my local. |
|
@shobhitchittora fork is an async operation that does not keep the event loop alive. Therefore the test exits before the spawned file is done and in that case the test will not receive the message and the test fails. |
|
Ping @shobhitchittora |
|
@BridgeAR I've removed Also I've no clue about how to make the test wait for the fork's response. |
|
@shobhitchittora I think using |
|
@lundibundi Are you sure? I don't see a point of using on |
|
Theoretically, it should make current node process wait until fork finishes as we are listening on its close event. Also, this seems to be the way it's done with other |
|
Any idea why the status code returned by child is Also I tried running the child js file in local and got the below error - TypeError: process.send is not a function
at Object.<anonymous> (/Users/schittora/Desktop/node/test/fixtures/child-process-spawn-node.js:10:9)
at Module._compile (module.js:635:30)
at Object.Module._extensions..js (module.js:646:10)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)
at Function.Module._load (module.js:489:3)
at Function.Module.runMain (module.js:676:10)
at startup (bootstrap_node.js:187:16)
at bootstrap_node.js:608:3 |
|
Sorry, forgot about this one. |
|
@lundibundi Everything looks green 💚 . Thanks!! 👍 |
PR-URL: nodejs#22416 Fixes: nodejs#20749 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
|
Landed in 0d9d32a |
Closes: #20749
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesNOTE: Run test using -
python ./tools/test.py parallel/test-child-process-fork-options.jsAffected subsystem(s)
child_process / fork