8000 http2: remove unused nghttp2 error list by addaleax · Pull Request #21827 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    http2: remove unused nghttp2 error list #21827

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    addaleax wants to merge 1 commit into from
    Closed

    http2: remove unused nghttp2 error list #21827

    addaleax wants to merge 1 commit into from

    Conversation

    @addaleax
    Copy link
    Member
    @addaleax addaleax commented Jul 15, 2018

    Remove a list of HTTP2 errors as well as nghttp2_errname()
    that converted an integer nghttp2 error code to a string
    representation.

    We already use nghttp2_strerror() for this, which
    is provided by nghttp2 returns a better error string anyway.

    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • commit message follows commit guidelines

    @addaleax
    http2: remove unused nghttp2 error list
    4e69a40 
    Remove a list of HTTP2 errors as well as `nghttp2_errname()`
that converted an integer nghttp2 error code to a string
representation.

We already use `nghttp2_strerror()` for this, which
is provided by nghttp2 returns a better error string anyway.
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Jul 15, 2018

    @addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/282/pipeline

    @nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Jul 15, 2018
    @trivikr
    Copy link
    Member
    trivikr commented Jul 16, 2018

    \cc @nodejs/http2

    mcollina
    mcollina approved these changes Jul 16, 2018
    View reviewed changes
    Copy link
    Member
    @mcollina mcollina left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @trivikr
    Copy link
    Member
    trivikr commented Jul 18, 2018

    CI: https://ci.nodejs.org/job/node-test-pull-request/15926/

    @trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2018
    @addaleax
    Copy link
    Member Author
    addaleax commented Jul 18, 2018 •
    edited by BridgeAR
    Loading

    OS X failure is being addressed by #21861, Windows failure is being tracked at #21425

    OS X rebuild: https://ci.nodejs.org/job/node-test-commit-osx/19899/
    Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19373/ ✔️

    @BridgeAR
    Copy link
    Member
    BridgeAR commented Jul 18, 2018

    OS X failed again.

    Rebuild: https://ci.nodejs.org/job/node-test-commit-osx/19904/

    @addaleax
    Copy link
    Member Author
    addaleax commented Jul 19, 2018

    Landed in 4f47f62

    @addaleax addaleax closed this Jul 19, 2018
    @addaleax addaleax deleted the http2-strerror branch July 19, 2018 17:46
    addaleax added a commit that referenced this pull request Jul 19, 2018
    @addaleax
    http2: remove unused nghttp2 error list
    4f47f62 
    Remove a list of HTTP2 errors as well as `nghttp2_errname()`
that converted an integer nghttp2 error code to a string
representation.

We already use `nghttp2_strerror()` for this, which
is provided by nghttp2 returns a better error string anyway.

PR-URL: #21827
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    targos pushed a commit that referenced this pull request Jul 20, 2018
    @addaleax @targos
    http2: remove unused nghttp2 error list
    1e15581 
    Remove a list of HTTP2 errors as well as `nghttp2_errname()`
that converted an integer nghttp2 error code to a string
representation.

We already use `nghttp2_strerror()` for this, which
is provided by nghttp2 returns a better error string anyway.

PR-URL: #21827
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @targos targos mentioned this pull request Jul 31, 2018
    Merged
    This was referenced Aug 1, 2018
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
    @addaleax @kjin
    http2: remove unused nghttp2 error list
    f3c9f5a 
    Remove a list of HTTP2 errors as well as `nghttp2_errname()`
that converted an integer nghttp2 error code to a string
representation.

We already use `nghttp2_strerror()` for this, which
is provided by nghttp2 returns a better error string anyway.

PR-URL: nodejs#21827
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
    @addaleax @kjin
    http2: remove unused nghttp2 error list
    3a1e581 
    Remove a list of HTTP2 errors as well as `nghttp2_errname()`
that converted an integer nghttp2 error code to a string
representation.

We already use `nghttp2_strerror()` for this, which
is provided by nghttp2 returns a better error string anyway.

PR-URL: nodejs#21827
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
    @addaleax @kjin
    http2: remove unused nghttp2 error list
    d78a7b3 
    Remove a list of HTTP2 errors as well as `nghttp2_errname()`
that converted an integer nghttp2 error code to a string
representation.

We already use `nghttp2_strerror()` for this, which
is provided by nghttp2 returns a better error string anyway.

PR-URL: nodejs#21827
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
    @addaleax @BethGriggs
    http2: remove unused nghttp2 error list
    745e1e6 
    Remove a list of HTTP2 errors as well as `nghttp2_errname()`
that converted an integer nghttp2 error code to a string
representation.

We already use `nghttp2_strerror()` for this, which
is provided by nghttp2 returns a better error string anyway.

Backport-PR-URL: #22850
PR-URL: #21827
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
    Merged
    @beevelop beevelop mentioned this pull request Nov 20, 2018
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @mcollina mcollina mcollina approved these changes

    @jasnell jasnell jasnell approved these changes

    @lpinca lpinca lpinca approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    @trivikr trivikr trivikr approved these changes

    Assignees

    No one assigned

    Labels

    author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    9 participants

    @addaleax @nodejs-github-bot @trivikr @BridgeAR @mcollina @jasnell @lpinca @cjihrig @Trott
    0