8000 [v9.x backport] lib: rename js source to lower snake_case by danbev · Pull Request #19969 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    [v9.x backport] lib: rename js source to lower snake_case #19969

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    danbev wants to merge 1 commit into from
    Closed

    [v9.x backport] lib: rename js source to lower snake_case #19969

    danbev wants to merge 1 commit into from

    Conversation

    @danbev
    Copy link
    Contributor
    @danbev danbev commented Apr 12, 2018

    This commit renames all JavaScript source files in lib to lower
    snake_case.

    PR-URL: #19556
    Reviewed-By: Anna Henningsen anna@addaleax.net
    Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
    Reviewed-By: James M Snell jasnell@gmail.com
    Reviewed-By: Tiancheng "Timothy" Gu timothygu99@gmail.com

    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • commit message follows commit guidelines

    @nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v9.x labels Apr 12, 2018
    @danbev
    Copy link
    Contributor Author
    danbev commented Apr 12, 2018

    CI: https://ci.nodejs.org/job/node-test-pull-request/14217/

    TimothyGu
    TimothyGu approved these changes Apr 28, 2018
    View reviewed changes
    Copy link
    Member
    @TimothyGu TimothyGu left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM, but this now has a conflict.

    @danbev
    lib: rename js source to lower snake_case
    f1326ec 
    This commit renames all JavaScript source files in lib to lower
snake_case.

PR-URL: nodejs#19556
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    @danbev danbev force-pushed the backport-19556-to-v9.x branch from bd20b6f to f1326ec Compare April 30, 2018 07:36
    @danbev
    Copy link
    Contributor Author
    danbev commented Apr 30, 2018

    Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/14593/

    @targos
    Copy link
    Member
    targos commented Jun 6, 2018

    Landed in 679f362

    @targos targos closed this Jun 6, 2018
    targos pushed a commit that referenced this pull request Jun 6, 2018
    @danbev @targos
    lib: rename js source to lower snake_case
    679f362 
    This commit renames all JavaScript source files in lib to lower
snake_case.

Backport-PR-URL: #19969
PR-URL: #19556
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    @danbev danbev deleted the backport-19556-to-v9.x branch July 2, 2018 07:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @TimothyGu TimothyGu TimothyGu approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    lib / src Issues and PRs related to general changes in the lib or src directory.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @danbev @targos @TimothyGu @nodejs-github-bot
    0