8000 n-api: take n-api out of experimental by mhdawson · Pull Request #19262 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    n-api: take n-api out of experimental #19262

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    mhdawson wants to merge 2 commits into from
    Closed

    n-api: take n-api out of experimental #19262

    mhdawson wants to merge 2 commits into from

    Conversation

    @mhdawson
    Copy link
    Member
    @mhdawson mhdawson commented Mar 9, 2018

    Take n-api out of experimental as per:
    nodejs/TSC#501

    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • [X ] tests and/or benchmarks are included
    • documentation is changed or added
    • commit message follows commit guidelines

    @nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 9, 2018
    @mhdawson mhdawson mentioned this pull request Mar 9, 2018
    Closed
    mcollina
    mcollina approved these changes Mar 9, 2018
    View reviewed changes
    Copy link
    Member
    @mcollina mcollina left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    cjihrig
    cjihrig approved these changes Mar 9, 2018
    View reviewed changes
    src/node.cc Outdated
    Copy link
    Contributor
    @cjihrig cjihrig Mar 9, 2018

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think it would be better to combine the mp->nm_version == -1 check with the one in the else if

    @jasnell jasnell added this to the 10.0.0 milestone Mar 9, 2018
    @mhdawson
    Copy link
    Member Author
    mhdawson commented Mar 9, 2018

    @cjihrig pushed commit to address your comment.

    CI run: https://ci.nodejs.org/job/node-test-pull-request/13611/

    @mhdawson mhdawson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2018
    @richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 10, 2018
    richardlau
    richardlau reviewed Mar 10, 2018
    View reviewed changes
    doc/api/n-api.md Outdated
    Copy link
    Member
    @richardlau richardlau Mar 10, 2018

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Do we track changes like this in the documentation with YAML metadata?

    Copy link
    Member Author
    @mhdawson mhdawson Mar 14, 2018

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looking at the existing docs, I don't think so.

    @mhdawson
    Copy link
    Member Author
    mhdawson commented Mar 14, 2018

    rebased, new ci

    ci: https://ci.nodejs.org/job/node-test-pull-request/13673/

    @mhdawson
    Copy link
    Member Author
    mhdawson commented Mar 14, 2018

    Faiure on linux was known issue: #18657. Rest of CI is green so we are good to go, will land.

    @mhdawson mhdawson added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 14, 2018
    @mhdawson
    Copy link
    Member Author
    mhdawson commented Mar 14, 2018

    land as cd7d7b1

    @mhdawson mhdawson closed this Mar 14, 2018
    mhdawson added a commit that referenced this pull request Mar 14, 2018
    @mhdawson
    n-api: take n-api out of experimental
    cd7d7b1 
    Take n-api out of experimental as per:
nodejs/TSC#501

PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @lovell lovell mentioned this pull request Mar 16, 2018
    Closed
    @targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2018
    @targos
    Copy link
    Member
    targos commented Mar 17, 2018

    Do we want to land this on v9.x?

    @mcollina
    Copy link
    Member
    mcollina commented Mar 17, 2018

    I would recommend to land this on both 8 and 9.

    @richardlau richardlau mentioned this pull request Apr 16, 2018
    Closed
    MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
    @mhdawson @MylesBorins
    n-api: take n-api out of experimental
    2c1190a 
    Take n-api out of experimental as per:
nodejs/TSC#501

Backport-PR-URL: #19447
PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
    Merged
    @bnoordhuis bnoordhuis mentioned this pull request Apr 18, 2018
    Closed
    4 tasks
    @mhdawson
    Copy link
    Member Author
    mhdawson commented Jun 1, 2018

    @gabrielschulhof one of the two of us need to do this backport.

    @mhdawson
    Copy link
    Member Author
    mhdawson commented Jun 1, 2018

    Working on backport PR

    @mhdawson mhdawson mentioned this pull request Jun 1, 2018
    Closed
    4 tasks
    @mhdawson
    Copy link
    Member Author
    mhdawson commented Jun 1, 2018

    PR against v8.x-staging -> #21083.

    @MylesBorins can you confirm PR against v8.x-staging is still the right way to go.

    @mhdawson
    Copy link
    Member Author
    mhdawson commented Jun 1, 2018

    Not sure if backported tag should be added before PR lands so removed for now.

    mhdawson added a commit that referenced this pull request Jun 7, 2018
    @mhdawson
    n-api: take n-api out of experimental
    084ef60 
    Take n-api out of experimental as per:
nodejs/TSC#501

Backport-PR-URL: #21083
PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @ryzokuken
    Copy link
    Contributor
    ryzokuken commented Jun 11, 2018

    Isn't this already backported successfully? Removing tag.

    MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
    @mhdawson @MylesBorins
    n-api: take n-api out of experimental
    35055a1 
    Take n-api out of experimental as per:
nodejs/TSC#501

Backport-PR-URL: #21083
PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
    Merged
    rvagg pushed a commit that referenced this pull request Aug 16, 2018
    @mhdawson @rvagg
    n-api: take n-api out of experimental
    0b2f527 
    Take n-api out of experimental as per:
nodejs/TSC#501

Backport-PR-URL: #21083
PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    MylesBorins added a commit that referenced this pull request Aug 17, 2018
    @MylesBorins
    2018-09-04, Version 8.12.0 'Carbon' (LTS)
    46b0a4e 
    Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    #21592
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
    BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Aug 29, 2018
    @MylesBorins @BethGriggs
    2018-09-04, Version 8.12.0 'Carbon' (LTS)
    f52ae67 
    Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    nodejs#18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    nodejs#19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    nodejs#18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    nodejs#18399
  - support windowsHide option for workers (Todd Wong)
    nodejs#17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    nodejs#18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    nodejs#21592
  - upgrade libuv to 1.19.2 (cjihrig)
    nodejs#18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    nodejs#21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    nodejs#18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    nodejs#19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    nodejs#15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    nodejs#16644
  - add http fallback options to .createServer (Peter Marton)
    nodejs#15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    nodejs#19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    nodejs#18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    nodejs#16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    nodejs#17600
  - node internals' postmortem metadata (Matheus Marchini)
    nodejs#14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    nodejs#19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    nodejs#18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    nodejs#18186

PR-URL: nodejs#21593
    MylesBorins added a commit that referenced this pull request Sep 3, 2018
    @MylesBorins
    2018-09-04, Version 8.12.0 'Carbon' (LTS)
    6f4daa3 
    Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.4.1 (Kat Marchán)
    #22591
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
    MylesBorins added a commit that referenced this pull request Sep 6, 2018
    @MylesBorins
    2018-09-11, Version 8.12.0 'Carbon' (LTS)
    0c73307 
    Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    #21592
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
    MylesBorins added a commit that referenced this pull request Sep 10, 2018
    @MylesBorins
    2018-09-11, Version 8.12.0 'Carbon' (LTS)
    731eed2 
    Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    #21592
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
    MylesBorins added a commit that referenced this pull request Sep 11, 2018
    @MylesBorins
    2018-09-11, Version 8.12.0 'Carbon' (LTS)
    121439a 
    Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    #21592
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
    @mhdawson mhdawson deleted the napi-nexp branch September 30, 2019 13:15
    abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
    @mhdawson
    n-api: take n-api out of experimental
    895d8ec 
    Take n-api out of experimental as per:
nodejs/TSC#501

PR-URL: nodejs/node#19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @richardlau richardlau richardlau left review comments

    @mcollina mcollina mcollina approved these changes

    @fhinkel fhinkel fhinkel approved these changes

    @jasnell jasnell jasnell approved these changes

    @targos targos targos approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    +1 more reviewer

    @devsnek devsnek devsnek approved these changes

    Reviewers whose approvals may not affect merge require 6A7B ments

    Assignees

    No one assigned

    Labels

    c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

    Projects

    None yet

    Milestone

    10.0.0

    Development

    Successfully merging this pull request may close these issues.
    0