8000 (v6.x backport) crypto: reuse variable instead of reevaluation by tniessen · Pull Request #19115 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

(v6.x backport) crypto: reuse variable instead of reevaluation #19115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tniessen wants to merge 1 commit into from
Closed

(v6.x backport) crypto: reuse variable instead of reevaluation #19115

tniessen wants to merge 1 commit into from

Conversation

< 8000 div class="js-discussion ml-0 pl-0 ml-md-6 pl-md-3" >
@tniessen
Copy link
Member
@tniessen tniessen commented Mar 4, 2018

Backport of #17735 to v6.x.

@tniessen
crypto: reuse variable instead of reevaluation
1e2b5f0 
PR-URL: nodejs#17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. v6.x labels Mar 4, 2018
@tniessen tniessen mentioned this pull request Mar 4, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@tniessen @MylesBorins
crypto: reuse variable instead of reevaluation
e2b7ad8 
Backport-PR-URL: #19115
PR-URL: #17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins
Copy link
Contributor
MylesBorins commented Mar 20, 2018

landed in e2b7ad8

MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen @MylesBorins
crypto: reuse variable instead of reevaluation
1e1478a 
Backport-PR-URL: #19115
PR-URL: #17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen @MylesBorins
crypto: reuse variable instead of reevaluation
969398d 
Backport-PR-URL: #19115
PR-URL: #17735
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MylesBorins MylesBorins

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen @MylesBorins @lpinca @gibfahn @nodejs-github-bot
0