8000 doc: Update HTTP -> HTTPS in doc/api by him2him2 · Pull Request #17263 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

doc: Update HTTP -> HTTPS in doc/api #17263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
him2him2 wants to merge 1 commit into from
Closed

doc: Update HTTP -> HTTPS in doc/api #17263

him2him2 wants to merge 1 commit into from

Conversation

@him2him2
Copy link
Contributor
@him2him2 him2him2 commented Nov 22, 2017 •
edited
Loading

URLs were updated to use HTTPS protocol in doc/api files.
Update URLs to reduce 301 Redirects for speed.

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 22, 2017
maclover7
maclover7 reviewed Nov 23, 2017
View reviewed changes
Copy link
Contributor
@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment :)

doc/api/crypto.md Outdated
Copy link
Contributor
@maclover7 maclover7 Nov 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible typo, should this be element?

@him2him2
Copy link
Contributor Author
him2him2 commented Nov 23, 2017

@maclover7 Nice catch. Thanks for the second set of eyes. I have fixed the typo.

MylesBorins
MylesBorins approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor
@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: can you please include the subsystem in the commit message and
doc: Update HTTP -> HTTPS in...

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 23, 2017
@him2him2
doc: Update HTTP -> HTTPS in doc/api
4686458 
URLs were updated to use HTTPS protocol in doc/api files.
Update URLs to reduce 301 Redirects for speed.
@him2him2 him2him2 changed the title Update HTTP -> HTTPS in doc/api doc: Update HTTP -> HTTPS in doc/api Nov 23, 2017
@apapirovski
Copy link
Contributor
apapirovski commented Nov 23, 2017

Landed in 7ab7840

Thank you for the contribution!

apapirovski pushed a commit that referenced this pull request Nov 23, 2017
@him2him2 @apapirovski
doc: update http URLs to https in doc/api
7ab7840 
PR-URL: #17263
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@him2him2 him2him2 deleted the _Fix_doc/api_HTTPS branch November 24, 2017 06:16
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@him2him2 @MylesBorins
doc: update http URLs to https in doc/api
f185079 
PR-URL: #17263
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@him2him2 @MylesBorins
doc: update http URLs to https in doc/api
c676129 
PR-URL: #17263
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@him2him2 @gibfahn
doc: update http URLs to https in doc/api