8000 test: remove unused parameter by tniessen · Pull Request #16935 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

test: remove unused parameter #16935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tniessen wants to merge 1 commit into from
Closed

test: remove unused parameter #16935

tniessen wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member
@tniessen tniessen commented Nov 10, 2017
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@tniessen tniessen added the test Issues and PRs related to the tests. label Nov 10, 2017
@tniessen
Copy link
Member Author
tniessen commented Nov 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11338/

@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Nov 10, 2017
@jasnell
Copy link
Member
jasnell commented Nov 12, 2017

This needs a rebase to land

@tniessen
Copy link
Member Author
tniessen commented Nov 12, 2017

I had planned to do this separately, but it seems like I incorporated this change in the first commit of #16938 (c85977c#diff-cfb6bf960da32b20d85d9bf60f72d3d3L41).

@tniessen tniessen closed this Nov 12, 2017
This was referenced Mar 9, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+4 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@refack refack refack approved these changes

@danbev danbev danbev approved these changes

@XadillaX XadillaX XadillaX approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stream 5712 Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@tniessen @jasnell @apapirovski @refack @danbev @lpinca @cjihrig @XadillaX @gireeshpunathil @mscdex
0