doc: fix typo in Buffer.from(string, [encoding]) #15013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Aug 24, 2017
jasnell
approved these changes
Aug 24, 2017
Member
There was a problem hiding this comment.
this should not need to wait the 48 hours to land :-)
1a0f19a to
88b8592
Compare
Member
|
@Ginden Looks like you have accidentally pushed commits fixing tests to this PR? |
2 tasks
Author
|
@joyeecheung It seems like history on nodejs/node was rebased and it's artifact. Fixed. |
joyeecheung
approved these changes
Aug 24, 2017
Member
|
Landed in abced13. Thanks for your contribution and welcome to Node.js! |
joyeecheung
pushed a commit
that referenced
this pull request
Aug 24, 2017
PR-URL: #15013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Aug 25, 2017
PR-URL: nodejs/node#15013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 28, 2017
PR-URL: nodejs/node#15013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #15013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #15013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 20, 2017
PR-URL: #15013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc