8000 doc: use stricter indentation checking for docs by Trott · Pull Request #13950 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

doc: use stricter indentation checking for docs #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 2 commits into from
Closed

doc: use stricter indentation checking for docs #13950

Trott wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member
@Trott Trott commented Jun 27, 2017

First commit:

doc: fix indentation issues in sample code

In preparation for stricter ESLint indentation checking, fix a few
issues in sample code.

Second commit:

doc: use stricter indentation checking for docs

Use stricter ESLint indent checking for sample code in docs.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

doc tools

Trott added 2 commits June 27, 2017 13:32
@Trott
doc: fix indentation issues in sample code
4284a7a 
In preparation for stricter ESLint indentation checking, fix a few
issues in sample code.
@Trott
doc: use stricter indentation checking for docs
6e2abc9 
Use stricter ESLint indent checking for sample code in docs.
@Trott Trott added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jun 27, 2017
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 27, 2017
@vsemozhetbyt
Copy link
Contributor
vsemozhetbyt commented Jun 27, 2017

Linter CI: https://ci.nodejs.org/job/node-test-linter/10100/

mhdawson
mhdawson approved these changes Jun 28, 2017
View reviewed changes
Copy link
Member
@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author
Trott commented Jun 29, 2017

Landed in 8969c1b and 7477f9b

@Trott Trott closed this Jun 29, 2017
@addaleax addaleax mentioned this pull request Jun 30, 2017
Merged
@MylesBorins
Copy link
Contributor
MylesBorins commented Aug 14, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

@Trott Trott mentioned this pull request Aug 15, 2017
Closed
7 tasks
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the indent-md branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

+2 more reviewers

@refack refack refack approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
0