test: Skip intl-no-icu-data test when not (Intl and smallICU) #12226
Conversation
The --icu-data-dir flag applies only when the code was originally compiled with --with-intl=small-icu.
|
I don't think these changes are sufficient for the case without intl ( |
|
@richardlau Since the skip condition in the PR is
having |
|
@evantorrie but that won't get executed because the test runner appends |
|
@richardlau Ah yes, you're correct. In my particular case, the requirement was to skip the test when To fix the case for --with-intl=none, I guess we'd have to change the actual test runner python script? |
Either that or the test would have to be rewritten to not use cc @nodejs/testing |
|
I think the "rewrite the test to use a child process" option will work much better than the "rewrite the test runner". |
|
If you want to go down the modifying the test runner route, #12485 is doing something similar for openssl options. |
| common.skip('not (Intl AND SmallICU)'); | ||
| return; | ||
| } | ||
| assert.deepStrictEqual(Intl.NumberFormat.supportedLocalesOf('en'), []); |
There was a problem hiding this comment.
Hmm... I think Intl.NumberFormat.supportedLocalesOf('en') with empty icu dir should be [] anyway.
|
#13053 makes a bad |
The --icu-data-dir flag applies only when the code was originally
compiled with --with-intl=small-icu. Skip the test in all other cases
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Fixes: #12198