8000 doc: make os api doc more consistent by evanlucas · Pull Request #10994 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    doc: make os api doc more consistent #10994

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    evanlucas wants to merge 1 commit into from
    Closed

    doc: make os api doc more consistent #10994

    evanlucas wants to merge 1 commit into from

    Conversation

    @evanlucas
    Copy link
    Contributor
    @evanlucas evanlucas commented Jan 25, 2017

    This adds a missing Returns to os.arch() as well as a missing added in
    version to os.constants.

    Checklist
    • documentation is changed or added
    • commit message follows commit guidelines
    Affected core subsystem(s)

    doc

    @evanlucas
    doc: make os api doc more consistent
    bbbf625 
    This adds a missing Returns to os.arch() as well as a missing added in
version to os.constants.
    @nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. lts-watch-v6.x labels Jan 25, 2017
    @lpinca
    Copy link
    Member
    lpinca commented Jan 25, 2017

    I guess this shouldn't wait the 48h if it gets enough LGTM.

    @gibfahn
    Copy link
    Member
    gibfahn commented Jan 25, 2017

    @lpinca I agree it doesn't need to, but there's also no particular rush right?

    @lpinca
    Copy link
    Member
    lpinca commented Jan 25, 2017

    ofc not.

    Fishrock123
    Fishrock123 approved these changes Jan 26, 2017
    View reviewed changes
    Copy link
    Contributor
    @Fishrock123 Fishrock123 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    jasnell pushed a commit that referenced this pull request Jan 27, 2017
    @evanlucas @jasnell
    doc: make os api doc more consistent
    4f1e235 
    This adds a missing Returns to os.arch() as well as a missing added in
version to os.constants.

PR-URL: #10994
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @jasnell
    Copy link
    Member
    jasnell commented Jan 27, 2017

    Landed in 4f1e235

    @jasnell jasnell closed this Jan 27, 2017
    @evanlucas evanlucas deleted the osconsistency branch January 27, 2017 22:06
    @evanlucas
    Copy link
    Contributor Author
    evanlucas commented Jan 27, 2017

    Thanks @jasnell, you beat me to it :]

    evanlucas added a commit that referenced this pull request Jan 31, 2017
    @evanlucas
    doc: make os api doc more consistent
    4be9e98 
    This adds a missing Returns to os.arch() as well as a missing added in
version to os.constants.

PR-URL: #10994
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @italoacasas italoacasas mentioned this pull request Jan 31, 2017
    Merged
    MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
    @evanlucas @MylesBorins
    doc: make os api doc more consistent
    7b121f1 
    This adds a missing Returns to os.arch() as well as a missing added in
version to os.constants.

PR-URL: #10994
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
    @evanlucas @MylesBorins
    doc: make os api doc more consistent
    c9b302b 
    This adds a missing Returns to os.arch() as well as a missing added in
version to os.constants.

PR-URL: #10994
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
    Merged
    andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
    @evanlucas @andrew749
    doc: make os api doc more consistent
    9568b14 
    This adds a missing Returns to os.arch() as well as a missing added in
version to os.constants.

PR-URL: nodejs/node#10994
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @jasnell jasnell jasnell approved these changes

    @lpinca lpinca lpinca approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    +2 more reviewers

    @Fishrock123 Fishrock123 Fishrock123 approved these changes

    @gibfahn gibfahn gibfahn approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    8 participants

    @evanlucas @lpinca @gibfahn @jasnell @Fishrock123 @cjihrig @MylesBorins @nodejs-github-bot
    0