8000 benchmark: keep decimals in results by mscdex · Pull Request #10559 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    benchmark: keep decimals in results #10559

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Merged
    mscdex merged 1 commit into from
    Jan 5, 2017
    Merged

    benchmark: keep decimals in results #10559

    mscdex merged 1 commit into from
    Jan 5, 2017
    +6 −4

    Conversation

    @mscdex
    Copy link
    Contributor
    @mscdex mscdex commented Jan 1, 2017 •
    edited
    Loading

    Some benchmarks' results are small values, so keeping decimals when running them manually (not comparing) can be helpful.

    Lint: https://ci.nodejs.org/job/node-test-linter/6124/
    Lint: https://ci.nodejs.org/job/node-test-linter/6125/

    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • commit message follows commit guidelines
    Affected core subsystem(s)
    • benchmark

    @mscdex mscdex added the benchmark Issues and PRs related to the benchmark subsystem. label Jan 1, 2017
    @benjamingr
    Copy link
    Member
    benjamingr commented Jan 3, 2017 •
    edited
    Loading

    I'm +1 on the suggestion but I find the regexp kind of hard to read. (Not blocking or anything, just pointing it out)

    @mscdex
    benchmark: keep decimals in results
    7889416 
    Some benchmarks' results are small values, so keeping decimals when
running them manually (not comparing) can be helpful.

PR-URL: nodejs#10559
Reviewed-By: James M Snell <jasnell@gmail.com>
    @mscdex mscdex force-pushed the benchmark-keep-decimals branch from b03c096 to 7889416 Compare January 5, 2017 07:49
    @mscdex mscdex merged commit 7889416 into nodejs:master Jan 5, 2017
    @mscdex mscdex deleted the benchmark-keep-decimals branch January 5, 2017 07:52
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
    @mscdex
    benchmark: keep decimals in results
    569bb21 
    Some benchmarks' results are small values, so keeping decimals when
running them manually (not comparing) can be helpful.

PR-URL: nodejs#10559
Reviewed-By: James M Snell <jasnell@gmail.com>
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
    @mscdex
    benchmark: keep decimals in results
    0466b59 
    Some benchmarks' results are small values, so keeping decimals when
running them manually (not comparing) can be helpful.

PR-URL: nodejs#10559
Reviewed-By: James M Snell <jasnell@gmail.com>
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
    @mscdex
    benchmark: keep decimals in results
    f792f8e 
    Some benchmarks' results are small values, so keeping decimals when
running them manually (not comparing) can be helpful.

PR-URL: nodejs#10559
Reviewed-By: James M Snell <jasnell@gmail.com>
    @italoacasas italoacasas mentioned this pull request Jan 25, 2017
    Closed
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
    @mscdex
    benchmark: keep decimals in results
    2f4577c 
    Some benchmarks' results are small values, so keeping decimals when
running them manually (not comparing) can be helpful.

PR-URL: nodejs#10559
Reviewed-By: James M Snell <jasnell@gmail.com>
    @italoacasas italoacasas mentioned this pull request Jan 29, 2017
    Merged
    @MylesBorins
    Copy link
    Contributor
    MylesBorins commented Mar 7, 2017

    this is not landing cleanly on LTS. Should it be backported? Add do-not-land label if not.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @jasnell jasnell jasnell approved these changes

    Assignees

    No one assigned

    Labels

    benchmark Issues and PRs related to the benchmark subsystem.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    5 participants

    @mscdex @benjamingr @MylesBorins @jasnell @nodejs-github-bot
    0