8000 test: improve the code in test-fs-access by edsadr · Pull Request #10542 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    test: improve the code in test-fs-access #10542

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    edsadr wants to merge 1 commit into from
    Closed

    test: improve the code in test-fs-access #10542

    edsadr wants to merge 1 commit into from

    Conversation

    @edsadr
    Copy link
    Member
    @edsadr edsadr commented Dec 30, 2016
    Checklist
    • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • tests and/or benchmarks are included
    • commit message follows commit guidelines
    Affected core subsystem(s)

    test

    Description of change
    • use const and let instead of var
    • use common.mustCall to control functions execution
    • use assert.ifError instead of assert.strictEqual for errors
    • use arrow functions

    @nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 30, 2016
    @mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 30, 2016
    lpinca
    lpinca reviewed Dec 31, 2016
    View reviewed changes
    test/parallel/test-fs-access.js Outdated
    Copy link
    Member
    @lpinca lpinca Dec 31, 2016

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nit: it doesn't harm but I think the use of common.mustCall() is not necessary here.

    @edsadr
    Copy link
    Member Author
    edsadr commented Dec 31, 2016

    @lpinca , did the nit

    @lpinca
    Copy link
    Member
    lpinca commented Dec 31, 2016

    CI: https://ci.nodejs.org/job/node-test-pull-request/5649/

    @edsadr
    test: improve the code in test-fs-access
    43f21c5 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions
    @edsadr
    Copy link
    Member Author
    edsadr commented Jan 3, 2017

    solved the conflicts for this one after ff1efa6

    @lpinca
    Copy link
    Member
    lpinca commented Jan 6, 2017

    New CI: https://ci.nodejs.org/job/node-test-pull-request/5722/

    @lpinca
    Copy link
    Member
    lpinca commented Jan 6, 2017

    Landed in 6c7219e.

    @lpinca lpinca closed this Jan 6, 2017
    lpinca pushed a commit that referenced this pull request Jan 6, 2017
    @edsadr @lpinca
    test: improve test-fs-access
    6c7219e 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
    @edsadr
    test: improve test-fs-access
    9d302ae 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
    @edsadr
    test: improve test-fs-access
    649af4c 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @italoacasas italoacasas mentioned this pull request Jan 25, 2017
    Closed
    targos pushed a commit that referenced this pull request Jan 28, 2017
    @edsadr @targos
    test: improve test-fs-access
    e748adb 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @italoacasas italoacasas mentioned this pull request Jan 29, 2017
    Merged
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
    @edsadr
    test: improve test-fs-access
    b1c742e 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
    @edsadr
    test: improve test-fs-access
    b7745e5 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
    @edsadr @MylesBorins
    test: improve test-fs-access
    b85d15f 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
    @edsadr @MylesBorins
    test: improve test-fs-access
    f064520 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
    Merged
    andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
    @edsadr @andrew749
    test: improve test-fs-access
    215dfec 
    * use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs/node#10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @jasnell jasnell jasnell approved these changes

    @lpinca lpinca lpinca approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    Assignees

    No one assigned

    Labels

    fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    7 participants

    @edsadr @lpinca @jasnell @cjihrig @mscdex @MylesBorins @nodejs-github-bot
    0