8000 doc: add link to `net.Server` in tls.md by drifkin · Pull Request #10109 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    doc: add link to net.Server in tls.md #10109

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    drifkin wants to merge 1 commit into from
    Closed

    doc: add link to net.Server in tls.md #10109

    drifkin wants to merge 1 commit into from
    +1 −1

    Conversation

    @drifkin
    Copy link
    Contributor
    @drifkin drifkin commented Dec 4, 2016
    Checklist
    • documentation is changed or added
    • commit message follows commit guidelines
    Affected core subsystem(s)

    doc

    Description of change

    I was looking through the tls docs and it referenced the net docs without linking it. This change adds the link.

    I also did a quick grep through the other docs for similar phrases, and didn't find any instances to fix similar to this one.

    @nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Dec 4, 2016
    @silverwind
    Copy link
    Contributor
    silverwind commented Dec 5, 2016

    Thanks! Landed in 1d21c05.

    @silverwind silverwind closed this Dec 5, 2016
    silverwind pushed a commit that referenced this pull request Dec 5, 2016
    @drifkin @silverwind
    doc: add link to net.Server in tls.md
    1d21c05 
    PR-URL: #10109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
    Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
    @drifkin @Fishrock123
    doc: add link to net.Server in tls.md
    346204d 
    PR-URL: #10109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
    @Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
    Merged
    2 tasks
    jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
    @drifkin
    doc: add link to net.Server in tls.md
    17e6c96 
    PR-URL: nodejs#10109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
    MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
    @drifkin @MylesBorins
    doc: add link to net.Server in tls.md
    b5eae44 
    PR-URL: #10109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
    MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
    @drifkin @MylesBorins
    doc: add link to net.Server in tls.md
    b77d3d8 
    PR-URL: #10109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
    MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
    @drifkin @MylesBorins
    doc: add link to net.Server in tls.md
    d4f8efa 
    PR-URL: #10109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
    MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
    @drifkin @MylesBorins
    doc: add link to net.Server in tls.md
    f1f19da 
    PR-URL: #10109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
    This was referenced Dec 21, 2016
    Merged
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @addaleax addaleax addaleax approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    +1 more reviewer

    @silverwind silverwind silverwind approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    6 participants

    @drifkin @silverwind @addaleax @cjihrig @MylesBorins @nodejs-github-bot
    0