Add Windows Support #203
Add Windows Support #203
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@cjihrig thanks, updated! Let me know if this is not what you had in mind. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
bc1f28c to
cd6d64f
Compare
|
Rebased, applied the fixup and added a I understand that more reviews might be necessary before this can land, but when the time comes I won't be able to do it myself as I don't have write access in this repo. |
|
It would nice if we can have some appveyor coverage for this, but I think it's ready to land. Thanks for the work on this! |
This PR adds support to build llnode on Windows and load core files generated on other platforms. Debugging the Windows Node executable is still not working. This would be nice to have as a base to keep developing Windows support. However, if this is considered too green to land, it can serve as a straw-man for discussion and feedback is welcome.
This makes two relevant changes that are not restricted to Windows:
llnode.cmdscript because npm already creates that file pointing tollnode.sh.node-gypdirectly. This is necessary to compile the module using Clang instead of CL.Because this is not working to debug a live Windows executable, all tests fail. Still, it is possible to run
scan-test.jswith a core file generated on another platform as described in the README. The core file must be generated using a 32bit node executable as lldb is not ready for 64bit usage on Windows.Ref: #17