build: separate lldb_include_dir and lldb_lib_dir #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate detection of lldb headers and lldb shared libraries since the headers can be downloaded by us while the libraries cannot at the moment. On some systems we are not able to find the non-versioned liblldb dynamic library (`-llldb`) anyway, it's working fine until now because the lldb will resolve the symbols before loading the plugin, but this will have to be handled differently in the case of addons which need the symbols at build time. Also use ldd to find the correct name of the library. - Use the name `lldb_include_dir` and `lldb_lib_dir` and point them to subdirectories of the lldb installation to match the concepts in llvm-config. - Check the `$lldb_include_dir/lldb/API` for headers since some incomplete installations may not have the API headers installed. - Stop symlinking ./lldb because we will always run scripts/configure.js which can write the path to the headers in the config.gypi anyway. - Put the conditional flags in binding.gyp to target_defaults so they can be shared by the addon target later. - Add more logs in the configuration script about the result of each step. - Detect llvm-config once and use it if it's available later instead of always trying to run it in each configuration step.
Member
Author
|
The build log now looks like this Ubuntu 16.04 with lldb-3.9MacOS using lldb in XcodeMacOS using custom lldb 5.0FreeBSD with lldb 4.0 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
Addressed comments from @bnoordhuis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the headers can be downloaded by us while the libraries
cannot at the moment. On some systems we are not able to
find the non-versioned liblldb dynamic library (
-llldb) anyway,it's working fine until now because the lldb will resolve the
symbols before loading the plugin, but this will have to be handled
differently in the case of addons which need the symbols at build time.
Also use ldd to find the correct name of the library.
lldb_include_dirandlldb_lib_dirandpoint them to subdirectories of the lldb installation to
match the concepts in llvm-config.
$lldb_include_dir/lldb/APIfor headers since someincomplete installations may not have the API headers installed.
which can write the path to the headers in the config.gypi anyway.
can be shared by the addon target later.
step.
always trying to run it in each configuration step.
In preparation for the addon API.
Refs: #147