chore(types): mirror https://github.com/nodejs/node/pull/58930 #344
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 71.52% 71.55% +0.02%
==========================================
Files 117 117
Lines 9719 9726 +7
Branches 590 590
==========================================
+ Hits 6952 6959 +7
Misses 2764 2764
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the MDN URL mappings with the referenced Node.js change by templating the ArrayBufferView link and introducing new Web API entries.
- Replace a hardcoded ArrayBufferView URL with
DOC_MDN_BASE_URLtemplate - Add mappings for CloseEvent, EventSource, MessageEvent, DOMException, Storage, and WebSocket
Comments suppressed due to low confidence (2)
src/utils/parser/constants.mjs:362
- Add unit tests for these newly added API mappings (CloseEvent, EventSource, MessageEvent, DOMException, Storage, WebSocket) to verify they resolve to the expected URLs.
CloseEvent: `${DOC_MDN_BASE_URL}/API/CloseEvent`,
ovflowd
approved these changes
Jul 3, 2025
AugustinMauroy
approved these changes
Jul 3, 2025
bjohansebas
approved these changes
Jul 3, 2025
Member
|
Let's only merge this once the upstream PR gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/node#58930
CC @ovflowd