8000 rules: skip line-length rule for URLs and quoted lines by addaleax · Pull Request #30 · nodejs/core-validate-commit · GitHub
[go: up one dir, main page]
Skip to content

rules: skip line-length rule for URLs and quoted lines #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyeecheung merged 3 commits into from
Nov 2, 2018
Merged

rules: skip line-length rule for URLs and quoted lines #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8902c0
rules: skip line-length rule for URLs and quoted lines
addaleax Oct 13, 2018
9a11858
fixup! rules: skip line-length rule for URLs and quoted lines
addaleax Oct 13, 2018
6d11258
squash! fixup! rules: skip line-length rule for URLs and quoted lines
addaleax Oct 17, 2018
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/rules/line-length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ module.exports = {
var failed = false
for (let i = 0; i < parsed.body.length; i++) {
const line = parsed.body[i]
// Skip quoted lines, e.g. for original commit messages of V8 backports.
if (line.startsWith(' '))
continue
// Skip lines with URLs.
if (/https?:\/\//.test(line))
continue
if (line.length > len) {
failed = true
context.report({
Expand Down
64 changes: 64 additions & 0 deletions test/rules/line-length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,69 @@ ${'aaa'.repeat(30)}`
tt.end()
})

t.test('quoted lines', (tt) => {
const v = new Validator()
const context = new Commit({
sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea'
, author: {
name: 'Evan Lucas'
, email: 'evanlucas@me.com'
, date: '2016-04-12T19:42:23Z'
}
, message: `src: make foo mor foo-ey

Here’s the original code:

${'aaa'.repeat(30)}

That was the original code.
`
}, v)

context.report = (opts) => {
tt.pass('called report')
tt.equal(opts.id, 'line-length', 'id')
tt.equal(opts.string, '', 'string')
tt.equal(opts.level, 'pass', 'level')
}

Rule.validate(context, {
options: {
length: 72
}
})
tt.end()
})

t.test('URLs', (tt) => {
const v = new Validator()
const context = new Commit({
sha: 'e7c077c610afa371430180fbd447bfef60ebc5ea'
, author: {
name: 'Evan Lucas'
, email: 'evanlucas@me.com'
, date: '2016-04-12T19:42:23Z'
}
, message: `src: make foo mor foo-ey

https://${'very-'.repeat(80)}-long-url.org/
`
}, v)

context.report = (opts) => {
tt.pass('called report')
tt.equal(opts.id, 'line-length', 'id')
tt.equal(opts.string, '', 'string')
tt.equal(opts.level, 'pass', 'level')
}

Rule.validate(context, {
options: {
length: 72
}
})
tt.end()
})

t.end()
})
4 changes: 2 additions & 2 deletions test/validator.js
View file
Open in desktop
6AEB
Original file line number Diff line numberDiff line change
Expand Up @@ -205,11 +205,11 @@ test('Validator - real commits', (t) => {
const filtered = msgs.filter((item) => {
return item.level === 'fail'
})
tt.equal(filtered.length, 3, 'messages.length')
tt.equal(filtered.length, 2, 'messages.length')
const ids = filtered.map((item) => {
return item.id
})
const exp = ['line-length', 'line-length', 'title-length']
const exp = ['line-length', 'title-length']
tt.deepEqual(ids.sort(), exp.sort(), 'message ids')
tt.end()
})
Expand Down
0