8000 lookup: add yarn to lookup.json by arcanis · Pull Request #993 · nodejs/citgm · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@arcanis
Copy link
Contributor
@arcanis arcanis commented Sep 29, 2023

This PR is just an attempt to rebase #905 (cc @edvardchen)

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • contribution guidelines followed here

edvardchen and others added 19 commits September 28, 2022 18:12
OpenSSL not found
1. `packages/acceptance-tests/pkg-tests-specs/sources/https.test.js`
  1. `Https tests › it should fail to install if server uses non trusted certificate`

Cannot connect to Github through `git:` and `git+ssh:` protocols
1. `packages/acceptance-tests/pkg-tests-specs/sources/protocols/git.test.js`
    1. `Protocols › git: › it should resolve a git dependency (git+ssh://git@github.com/yarnpkg/util-deprecate.git#v1.0.1)`
    2. `it should resolve a git dependency (git://github.com/yarnpkg/util-deprecate.git#v1.0.1)` on Windows
no need to ignore big-endian platforms

Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
mark fedora as flaky instead of ignoring test cases which requires openSSL
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (468452d) 95.34% compared to head (8f124be) 95.32%.
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   95.34%   95.32%   -0.03%     
==========================================
  Files          28       28              
  Lines        2149     2139      -10     
==========================================
- Hits         2049     2039      -10     
  Misses        100      100              
Files Coverage Δ
lib/bin/citgm-all.js 94.49% <100.00%> (-0.05%) ⬇️
lib/bin/citgm.js 98.16% <ø> (-0.04%) ⬇️
lib/citgm.js 100.00% <100.00%> (ø)
lib/grab-module-data.js 88.42% <100.00%> (ø)
lib/package-manager/get-executable.js 100.00% <100.00%> (ø)
lib/package-manager/test.js 99.35% <100.00%> (-0.01%) ⬇️
lib/temp-directory.js 100.00% <100.00%> (ø)
lib/unpack.js 95.34% <100.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcanis
Copy link
Contributor Author
arcanis commented Sep 29, 2023

Something weird in the git history of this branch 🤔

@arcanis arcanis closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0